feat: input component now support icon libraries#13
Open
AdityaTeltia wants to merge 1 commit intoDksie09:mainfrom
Open
feat: input component now support icon libraries#13AdityaTeltia wants to merge 1 commit intoDksie09:mainfrom
AdityaTeltia wants to merge 1 commit intoDksie09:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the
Inputcomponent to support icon libraries (e.g.,lucide-react, Heroicons, Radix, custom React components) in addition to the existing string-based icons (such as Base64 or SVG paths).Previously, the
iconprop only accepted strings, which limited usage to inline SVGs or image paths. With this change, consumers can now pass React components directly as icons, enabling integration with third-party icon libraries.Changes
Updated
InputProps:icon?: string | React.ReactNodeUpdated render logic in
Input:iconis astring, it renders as<img>.iconis a ReactNode, it renders directly.Updated Storybook stories:
<Search />fromlucide-react).argTypesrule to disable Storybook controls for ReactNode icons while keeping string icons editable.Added Jest tests:
onIconClick.onIconClick.Screenshots / Examples
closes #12