borrow & lending #16
Merged
borrow & lending #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sovryn-layer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
creed-victor
force-pushed
the
feat/SOV-5222-implement-sc-interactions-to
branch
from
e5f30ac to
f2c0a59
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements borrow and lending functionality for a money market feature, along with supporting infrastructure improvements.
Key Changes:
- Added borrow and lend transaction flows with dialog UI components
- Implemented money market pool and reserve data fetching from on-chain contracts
- Enhanced caching system with Redis-based response caching and stale-while-revalidate support
- Added decimal formatting utilities (shortened and formatted representations)
Reviewed Changes
Copilot reviewed 54 out of 57 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/lib/decimal.ts | Added formatting methods for decimal display (formatted with separators, shortened with magnitude suffixes) |
| packages/shared/src/helpers.ts | Added address equality comparison helper |
| packages/sdk/src/types.ts | Refactored token types and expanded money market pool/reserve interfaces |
| packages/sdk/src/managers/money-market/money-market.manager.ts | New manager implementing borrow and supply operations with ERC20 and native token support |
| packages/sdk/src/lib/transaction.ts | Added approval transaction helper for ERC20 tokens |
| apps/web-app/src/components/MoneyMarket/components/BorrowDialog | New borrow dialog with form validation |
| apps/web-app/src/components/MoneyMarket/components/LendDialog | New lend dialog with form validation |
| apps/web-app/src/lib/transactions/store.ts | Enhanced transaction store with completion tracking and close callbacks |
| apps/indexer/src/app/plugins/cache.ts | New Redis-based caching plugin with background revalidation |
| apps/indexer/src/libs/loaders/money-market.ts | Added on-chain data fetching for pool reserves using contract ABIs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {balance && ( | ||
| <span className="ml-2 text-sm font-normal text-gray-400"> | ||
| (Balance:{' '} | ||
| {Decimal.from(balance.value, balance.decimals).toFormatted(88)}{' '} |
There was a problem hiding this comment.
The magic number 88 for decimal places is unclear. Consider extracting this to a named constant (e.g., MAX_DISPLAY_DECIMALS) or adding a comment explaining why 88 decimal places are used for balance display.
Suggested change
| {Decimal.from(balance.value, balance.decimals).toFormatted(88)}{' '} | |
| {Decimal.from(balance.value, balance.decimals).toFormatted(MAX_DISPLAY_DECIMALS)}{' '} |
apps/web-app/src/components/MoneyMarket/components/LendAssetsList/LendAssetsList.tsx
Show resolved
Hide resolved
Comment on lines
241
to
242
| // By default, don't cache error responses | ||
| if (reply.statusCode >= 400) return payload; |
There was a problem hiding this comment.
[nitpick] The condition reply.statusCode >= 400 will prevent caching of both client errors (4xx) and server errors (5xx). Consider whether client errors like 404 should be cached differently from server errors like 500, as 404s are typically stable while 500s may be transient.
Suggested change
| // By default, don't cache error responses | |
| if (reply.statusCode >= 400) return payload; | |
| // By default, don't cache server error responses (5xx) | |
| if (reply.statusCode >= 500) return payload; |
tiltom
requested changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sovryn.atlassian.net/browse/SOV-5236
https://sovryn.atlassian.net/browse/SOV-5221