Skip to content

New signatures fixes (for review only) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 67 commits into
base: signatures_without_new_fixes
Choose a base branch
from
Open

New signatures fixes (for review only) #30

wants to merge 67 commits into from

Conversation

@koirikivi
Copy link
Contributor

@koirikivi koirikivi commented Jul 13, 2022

This PR includes the new fixes added by me to the signatures branch:

  • Increased signatures TTL to 24h (2min is not enough, especially for ethereum)
  • Fixed federator listener leak on timeout in _requestSignaturesFromFederators
  • Added validation for signature deadlines
  • Added validation so one federator cannot sign multiple times (even if the signatures differ)
  • Improved federator tests
  • Fixed running single test a time by removing global state mutation from tests (This prevented running single test with it.only or jest -t and was generally ugly. Tests should always work in isolation)
  • General refactoring and code quality improvements.

shlumper and others added 30 commits February 7, 2022 12:32
@shlumper
bridge checker fix
7cdf333
@tjcloa
fix wss://testnet.sovryn.app/ws URI
b04e5c5 
wss://testnet.sovryn.app/ws -> wss://testnet.sovryn.app/websocket
@bravepooh
update bsc testnet rpc
a48158d
@shlumper
Merge branch 'master' of https://github.com/DistributedCollective/Bri…
530d365 
…dge-SC
@shlumper
remove shlumoer from email list
e82b913
@koirikivi
Add more logging
661de16
@koirikivi
Add even more logging
888280f
@koirikivi
Update docker tag
c9ae55b
@koirikivi
Check processed status before checking signatures
3c40c88
@koirikivi
Remove unused transactionSender variable
af7be38
@koirikivi
Fix error in docker image building docs
83d69f4
@koirikivi
Update last processed block numbers
73832e7
@koirikivi
Add more logs when signTransaction fails
899ade4
@koirikivi
Yet another new tag for debugging
ed9cbbf
@koirikivi
Fix typo in previous typo-fix commit
085938a
@koirikivi
Fix signTransaction error when more than one Cross event in a block
11522e2 
Passing filter: { id: } to getPastEvent doesn't work -- need to filter
in nodejs.
@koirikivi
Update last processed block numbers
62cf058
@koirikivi
10.12 tag
2d1bd58
@koirikivi
Bump signature TTL to 24h
72a8c87
@koirikivi
Fix listener leak on timeout
bfe26e6
@koirikivi
Remove unneeded debug logging
18733c4
@koirikivi
Add test for mismatching deadline
1fa433b
@koirikivi
Minor signatures test code refactoring
1197c77
@koirikivi
Add configurable signature request timeout
575ac33
@koirikivi
Change ropsten signature request timeout to 2 min
2387f2b
@koirikivi
Don't mutate global state in tests -- fix running a single federator …
b72408a 
…test a time
@koirikivi
Don't allow different signatures from the same signer
e33a008
@koirikivi
Validate deadlines when requesting signatures
d0b9478
@koirikivi
Require a buffer for signature deadlines
e479936
@koirikivi
10.13 tag
5098a20
koirikivi added 30 commits August 1, 2022 15:09
@koirikivi
Working BSC testnet RPC url
cbe9beb
@koirikivi
Update block numbers and BSC RPC Url
d584998
@koirikivi
9.12
92f1737
@koirikivi
Rename Globals to globals so that imports work on Linux too
7d3c7b1
@koirikivi
9.13
5e55d8f
@koirikivi
Merge branch 'master' into signatures-merge-check
4df9b4b
@koirikivi
Update federation addresses, block numbers and rpc urls
c7ca738
@koirikivi
Merge branch 'master' (early part) into signatures-merge-check
5028403
@koirikivi
Change the exposed port to 4444
eb80752
@koirikivi
Mainnet peers config
7664385
@koirikivi
Fault tolerance
02c487e
@koirikivi
Only wait for 5 min when polling avg gas interval
8f95389
@koirikivi
10.14 tag (federator update ready)
288f70d
@koirikivi
Remove --name, 10.15
561a720
@koirikivi
Temporarily edit the reset script to reset to signatures branch
32b7648
@koirikivi
Signatures-friendly config
b50b6b8
@koirikivi
Log number of peers on each iteration
45eeab5
@koirikivi
10.16
3700757
@koirikivi
Reset script shenanigans
1a48202
@koirikivi
Return peerAmount correctly
3d30745
@koirikivi
10.17
0045447
@koirikivi
Correct "other peer" amount
5abb35e
@koirikivi
Handle other peer amount correctly, more logging
68e0860
@koirikivi
10.18
2cf8d97
@koirikivi
Fix reset script
8aaaaf8
@koirikivi
Test
5dd12c2
@koirikivi
FIX IT
07cda0e
@koirikivi
Update config
3040cef
@koirikivi
Reset script update
2852a54
@koirikivi
10.19
89083fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ororopickpocket ororopickpocket ororopickpocket approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@koirikivi @ororopickpocket @shlumper @tjcloa @bravepooh