-
Notifications
You must be signed in to change notification settings - Fork 4
ENG-1201 Update roamjs-components and use proper backend query signature #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-1201 Update roamjs-components and use proper backend query signature #640
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThe PR removes TypeScript ignore directives, Promise.resolve wrappers around Roam API calls, unnecessary comments, and refines type assertions across multiple utility and component files. A roamjs-components dependency is also bumped. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes The changes follow consistent patterns across multiple files (Promise.resolve removal, type assertion refinement, ts-ignore removal), but span 7 files with varying contexts. While individually straightforward, verification of type safety improvements and confirmation that removal of Promise.resolve wrappers maintain correct async semantics requires attention across all utility functions. Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
💤 Files with no reviewable changes (3)
🧰 Additional context used📓 Path-based instructions (5)**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/main.mdc)
Files:
apps/roam/**/*.{js,ts,tsx,jsx,json}📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
apps/roam/**/*.{ts,tsx,jsx,js,css,scss}📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
apps/roam/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
apps/roam/**📄 CodeRabbit inference engine (.cursor/rules/roam.mdc)
Files:
🧠 Learnings (19)📓 Common learnings📚 Learning: 2025-10-18T18:58:16.100ZApplied to files:
📚 Learning: 2025-06-22T10:40:52.752ZApplied to files:
📚 Learning: 2025-11-05T21:57:14.909ZApplied to files:
📚 Learning: 2025-11-25T00:52:41.934ZApplied to files:
📚 Learning: 2025-11-06T13:48:35.007ZApplied to files:
📚 Learning: 2025-11-23T23:53:43.094ZApplied to files:
📚 Learning: 2025-12-19T16:59:40.640ZApplied to files:
📚 Learning: 2025-07-13T16:47:14.352ZApplied to files:
📚 Learning: 2025-06-17T23:37:45.289ZApplied to files:
📚 Learning: 2025-06-17T23:37:45.289ZApplied to files:
📚 Learning: 2025-11-25T00:52:41.934ZApplied to files:
📚 Learning: 2025-11-25T00:52:41.934ZApplied to files:
📚 Learning: 2025-11-25T00:52:41.934ZApplied to files:
📚 Learning: 2025-08-11T19:09:58.252ZApplied to files:
📚 Learning: 2025-11-25T00:52:41.934ZApplied to files:
📚 Learning: 2025-06-22T10:40:21.679ZApplied to files:
📚 Learning: 2025-06-23T11:49:45.457ZApplied to files:
📚 Learning: 2025-12-07T20:54:20.007ZApplied to files:
🧬 Code graph analysis (1)apps/roam/src/utils/syncDgNodesToSupabase.ts (1)
🔇 Additional comments (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
https://linear.app/discourse-graphs/issue/ENG-1201/update-roamjs-components-and-use-proper-backend-query-signature
Summary by CodeRabbit
Chores
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.