Skip to content

refactor: remove dead vault modules#382

Merged
1nonlypiece merged 2 commits into
Disciplr-Org:mainfrom
khanavi272-spec:chore/remove-dead-vault-modules
May 28, 2026
Merged

refactor: remove dead vault modules#382
1nonlypiece merged 2 commits into
Disciplr-Org:mainfrom
khanavi272-spec:chore/remove-dead-vault-modules

Conversation

@khanavi272-spec
Copy link
Copy Markdown
Contributor

Fixes #323

Changes

  • Removed dead src/routes/vaults_corrupted.ts
  • Extracted markVaultExpiries() into dedicated vaultExpiry.service.ts
  • Removed duplicate src/services/vault.ts
  • Updated imports to use canonical expiry service

Validation

  • npm run build
  • npm test

Notes

Most test suites passed successfully. Remaining failures are unrelated environment issues:

  • PostgreSQL connection acquisition
  • Prisma ESM/Jest configuration

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 26, 2026

@khanavi272-spec Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@khanavi272-spec
Copy link
Copy Markdown
Contributor Author

@1nonlypiece please merge

@1nonlypiece 1nonlypiece merged commit 8a95fd4 into Disciplr-Org:main May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead src/routes/vaults_corrupted.ts and src/services/vault.ts duplicate vault modules

2 participants