Fix hotpatch TLS, symbol mapping, and loader publication - #5808
Open
jkelleyrtp wants to merge 3 commits into
Open
Fix hotpatch TLS, symbol mapping, and loader publication#5808jkelleyrtp wants to merge 3 commits into
jkelleyrtp wants to merge 3 commits into
Conversation
Preserve Mach-O TLS through descriptor forwarding, relocate ELF TLS initializers, and retain symbol aliases without guessing ambiguous targets. Use linker-derived WASM allocation requirements and avoid publishing failed or superseded patches. Add binary fixtures and publication regression tests. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
Keep the native fixes and independent loader hardening without extending JumpTable. The layout transport, allocation changes, and their regression tests will be reviewed in a stacked follow-up. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <166158716+staging-devin-ai-integration[bot]@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and stacked follow-up
The WASM allocation/layout changes have been split into #5809, which is based on this branch. This PR no longer changes
JumpTableorsubsecond-types. It can be merged without accepting the public-type/wire-format extension.The WASM BSS/table-allocation fixes are intentionally deferred to that follow-up. Applying both PRs reproduces the previously tested combined implementation exactly.
Summary
Fix native binary-patching correctness issues and independent loader/publication issues found during the hotpatch audit.
Native binaries
__imp_normalization to Windows, and reject direct redirection to GNU IFUNC resolvers.Independent WASM and publication hardening
OnceLock, and invoke reload handlers after releasing their registry lock.Limits
HotFnAPI.Test plan
git diff main -- packages/subsecond/subsecond-types/src/lib.rs— no changes to the public jump-table type.cargo test -p dioxus-cli --bin dx --locked— all 170 tests pass after the split.cargo test -p subsecond-types -p subsecond --lib --locked— the runtime publication test passes; no layout tests remain insubsecond-types.cargo check -p subsecond --target wasm32-unknown-unknown --locked.Generated with Devin