Skip to content

CI: make Playwright install deterministic and cache browser downloads #5788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicoburns wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −12
Open

CI: make Playwright install deterministic and cache browser downloads #5788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
debfd26
CI: make Playwright install deterministic and cache browser downloads
nicoburns Aug 27, 2026
f00e444
CI: split npm ci and playwright browser install into separate steps
nicoburns Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,15 +354,22 @@ jobs:
cache-provider: "warpbuild"
workspaces: ${{ env.DIOXUS_WORKSPACE }}
# save-if: ${{ github.ref == 'refs/heads/main' }}
- name: Cache Playwright browsers
uses: actions/cache@v5
with:
path: ~\AppData\Local\ms-playwright
key: playwright-browsers-${{ runner.os }}-${{ hashFiles('packages/playwright-tests/package-lock.json') }}
- name: Install npm dependencies
working-directory: ${{ env.DIOXUS_WORKSPACE }}/packages/playwright-tests
run: npm ci
- name: Install Playwright browsers
working-directory: ${{ env.DIOXUS_WORKSPACE }}/packages/playwright-tests
run: npx playwright install chromium
- name: Playwright
working-directory: ${{ env.DIOXUS_WORKSPACE }}/packages/playwright-tests
env:
CARGO_INCREMENTAL: 1
run: |
npm ci
npm install -D @playwright/test
npx playwright install
npx playwright test
run: npx playwright test
# - name: Clean Windows artifacts before cache save
# if: always()
# shell: pwsh
Expand Down Expand Up @@ -415,20 +422,27 @@ jobs:
cache-workspace-crates: "true"
cache-provider: "warpbuild"
# save-if: ${{ github.ref == 'refs/heads/main' }}
- name: Cache Playwright browsers
uses: actions/cache@v5
with:
path: ${{ runner.os == 'Linux' && '~/.cache/ms-playwright' || '~/Library/Caches/ms-playwright' }}
key: playwright-browsers-${{ runner.os }}-${{ hashFiles('packages/playwright-tests/package-lock.json') }}
- name: Wipe dx cache
if: runner.os == 'Linux'
run: |
rm -rf ./target/dx
- name: Install npm dependencies
working-directory: ./packages/playwright-tests
run: npm ci
- name: Install Playwright browsers
working-directory: ./packages/playwright-tests
run: npx playwright install chromium
- name: Playwright
working-directory: ./packages/playwright-tests
env:
# The hot patch test requires incremental compilation
CARGO_INCREMENTAL: 1
run: |
npm ci
npm install -D @playwright/test
npx playwright install
npx playwright test
run: npx playwright test
- uses: actions/upload-artifact@v6
if: failure()
with:
Expand Down
2 changes: 1 addition & 1 deletion packages/playwright-tests/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/playwright-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
"author": "",
"license": "ISC",
"devDependencies": {
"@playwright/test": "^1.56.1"
"@playwright/test": "1.56.1"
}
}
Loading