V2-SC-007: Enforce Claim Lifecycle and Deadline Transitions - #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #358
Implements the canonical claim state machine and reusable transition guards.
Technical Scope
IV2Types.ClaimStateto supportVerificationOpen,ChallengeWindow,AwaitingSettlement,Disputed, andFinalizedtransitions.V2Lifecycle.sollogic to correctly enforce transitions between the canonical claim states.ClaimStatusChangedwithClaimStateChangedmapping(uint256 indexed claimId, IV2Types.ClaimState previousState, IV2Types.ClaimState newState, address indexed actor, uint64 timestamp, bytes32 reasonCode)inIClaims.sol.isClaimOpen,isClaimVerified, andisClaimDisputedinsideV2Lifecycleto reflect the respective groupings under the new enumeration.Security and Integrity Requirements Maintained
Finalizedis strictly validated as a terminal state.V2Errors.InvalidClaimStateTransitionboundaries.