feat: audit fixes - #225
Merged
dDevAhmed merged 1 commit intoMay 30, 2026
Merged
Conversation
…#186 DigiNodes#180 - Cap unbounded loops in createSnapshot - Replace constant MAX_SNAPSHOT_SIZE with configurable maxSnapshotSize (default 200) - Add setMaxSnapshotSize() admin function with ABSOLUTE_MAX_SNAPSHOT_SIZE (1000) hard cap DigiNodes#184 - Add sqrt implementation on-chain (WeightedStaking) - Add Babylonian _sqrt() for 18-decimal fixed-point numbers - Enable useSqrtWeighting flag (default true) to match API behaviour - Add setSqrtWeighting() governance toggle DigiNodes#185 - Prevent slashCooldown bypass via same-block slashing - Add lastSlashBlock mapping tracking last slash block per verifier - Revert with SlashSameBlock if verifier already slashed in current block - Applied to slash(), _slashInternal(), and criticalSlash() DigiNodes#186 - Allow 100% slash for critical failures - Add CRITICAL_SLASHER_ROLE with grantCriticalSlasherRole()/revokeCriticalSlasherRole() - Add criticalSlash() that bypasses maxSlashPercentage (up to MAX_SLASH_PERCENTAGE=100) - Still respects same-block protection Tests: 22 new tests in test/AuditFixes.test.ts, 0 regressions in existing suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#180 - Cap unbounded loops in createSnapshot
#184 - Add sqrt implementation on-chain (WeightedStaking)
#185 - Prevent slashCooldown bypass via same-block slashing
#186 - Allow 100% slash for critical failures
Tests: 22 new tests in test/AuditFixes.test.ts, 0 regressions in existing suites.
closes #180
closes #184
closes #185
closes #186