fix(weighted-staking): mitigate block.timestamp manipulation risk - #217
Merged
dDevAhmed merged 2 commits intoMay 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Closes #159
This PR hardens WeightedStaking.sol against miner-controlled block.timestamp manipulation during reward and staking window calculations.
The implementation replaces direct timestamp dependency in sensitive short-window calculations with safer bounded logic and introduces invariant-focused validation to reduce manipulation risk.
🧠 Problem Context
Audit issue identified:
Small timestamp windows can be influenced by miners/validators
Direct reliance on block.timestamp may allow:
premature unlocks
reward skewing
edge-window exploitation
Reference: Internal Ref #CO-159
Closes #189
This PR refines voter claim handling by optimizing how voter addresses are reused across repeated claim operations.
The implementation reduces redundant storage writes for high-frequency voters while preserving claim integrity and replay protection guarantees.