-
Notifications
You must be signed in to change notification settings - Fork 6
Correctly implement DType and DType_T #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75b18d9 to
2149b01
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 90.75% 90.78% +0.02%
==========================================
Files 70 70
Lines 2465 2473 +8
==========================================
+ Hits 2237 2245 +8
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a57233a to
0240932
Compare
0240932 to
b88c9ea
Compare
b88c9ea to
9b2a037
Compare
9b2a037 to
2a5491c
Compare
2a5491c to
d8415fe
Compare
shihab-dls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Few nits, and a type signature suggestion.
d8415fe to
ffe008d
Compare
ffe008d to
be2f8fc
Compare
shihab-dls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.