Add AttrR wait_for_value #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
force-pushed
the
wait-for-value
branch
from
50b132e to
75b18d9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 90.55% 90.75% +0.19%
==========================================
Files 69 70 +1
Lines 2414 2465 +51
==========================================
+ Hits 2186 2237 +51
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
force-pushed
the
wait-for-value
branch
from
75b18d9 to
2149b01
Compare
Improve pva test
GDYendell
force-pushed
the
wait-for-value
branch
7 times, most recently
from
2a5491c to
d8415fe
Compare
shihab-dls
requested changes
Dec 12, 2025
Contributor
shihab-dls
left a comment
shihab-dls
left a comment
There was a problem hiding this comment.
Sorry for the delay; This looks really good, and has cleaned up test_p4p nicely. A few nits and a concern, but happy with the implementation!
GDYendell
force-pushed
the
wait-for-value
branch
from
d8415fe to
ffe008d
Compare
GDYendell
force-pushed
the
wait-for-value
branch
from
ffe008d to
be2f8fc
Compare
shihab-dls
approved these changes
Dec 16, 2025
Contributor
shihab-dls
left a comment
shihab-dls
left a comment
There was a problem hiding this comment.
Looks good! Approving!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
wait_for_valuetoAttrRas a convenient way to wait for specific state before continuing with logic.This also makes
on_updateblocking by default for CA out records.