Improve Attribute hint validation and add Controller hint validation #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 90.38% 90.51% +0.12%
==========================================
Files 68 69 +1
Lines 2371 2403 +32
==========================================
+ Hits 2143 2175 +32
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GDYendell
force-pushed
the
type-hint-validation
branch
from
fe56f91 to
eb5d51e
Compare
In future, this should be used in place of DType_T in non-generic contexts and DType_T should be bound to DType, but attempting this revealed some existing typing problems that were difficult to resolve. Remove incorrect Table dtype definition. It is actually just ndarray like Waveform.
Add HintedAttribute dataclass Allow for validation of Attribute type hints without a dtype
GDYendell
force-pushed
the
type-hint-validation
branch
from
eb5d51e to
aafcc37
Compare
1 task
shihab-dls
previously approved these changes
Dec 8, 2025
Contributor
shihab-dls
left a comment
shihab-dls
left a comment
There was a problem hiding this comment.
Looks really good to me, couldn't spot any issues; approving, with the most minor of nits.
GDYendell
force-pushed
the
type-hint-validation
branch
from
aafcc37 to
2499e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.