Hinted attribute validation #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
Attributenow raises aRuntimeError, even if the type and access mode match. To statically type hint anAttributeto be introspected during initialisation, only specify the type hint on the class - do not create a default instance, e.g.attr: AttrRW[int], notattr = AttrRW(Int()).Controller.attributesis now a read-only view. UseController.add_attributeto create Attributes, which will perform validation.Sorry the diff is a bit horrible because I moved methods around, but I think it has made it easier to read through the code.