Add new "404" tile structure to structure-mask.json#3731
Open
Smasherrio wants to merge 3 commits intoDexterHuang:masterfrom
Open
Add new "404" tile structure to structure-mask.json#3731Smasherrio wants to merge 3 commits intoDexterHuang:masterfrom
Smasherrio wants to merge 3 commits intoDexterHuang:masterfrom
Conversation
|
|
Smasherrio
commented
Mar 19, 2026
Author
Smasherrio
left a comment
There was a problem hiding this comment.
Fixed structure to access entities spawning within 0 .
Contributor
|
looks fine to me although for future refrence your original commit message is hard to read just "Adds dungeon layout featuring 404 motif" is fine you dont need to say how much of an avid player you are or how youd like it to be added to the game. or even where you added it as github shows all changes. |
Author
|
Sorry for being over explanative as it was my first pr in this repo I chose to be more detailed. Will keep concise for future references |
Contributor
|
dw i just wanted to tell you for furure refrence as your pr was hard to read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3730 New 404 Tile layout in Dungeons!
<Hey there devs!! I created a new tile structyre featuring the reknowned 404 Error Code in the dungeons layout code file. Am an avid player of CyberCode and would like this new dungeon layout to be introduced in the game. Thank you for your time. Hope you merge my request to the codebase>