chore: arreglar S7741 introducidos en #48#50
Merged
Conversation
Sonar prefiere comparacion directa con undefined cuando la variable es accesible sin throw (como globalThis.window). Las 3 ocurrencias en codigo de produccion las introduje yo en #48 al cambiar window.X por globalThis.window.X. Las 5 en tests/setup.ts no estan flageadas (Sonar excluye tests/** del analisis), no se tocan.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Cierra los 3 issues S7741 (Compare with `undefined` directly) que introduje yo en #48 al sustituir `window.X` por `globalThis.window.X`. Sonar prefiere comparacion directa con `undefined` cuando la variable es accesible sin throw — y `globalThis.window` lo es.
`typeof globalThis.window === 'undefined'` → `globalThis.window === undefined`
Ficheros
Por que solo 3 cuando hay mas
Las otras 5 ocurrencias del mismo patron viven en `tests/setup.ts`. `sonar-project.properties` excluye `tests/**` del analisis, asi que Sonar no las flagea. Las dejo igual para mantener consistencia con el resto del setup de tests.
Test plan