Upstream tracking #165
Draft
Upstream tracking #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knowing the Nix version a user is running on is useful when attempting to debug, and if the user is giving you the output of e.g. `nix build ... --debug`, you won't have to ask for the version separately since it'll be in the log. Requiring 2 `v`s was a conscious decision: `-v` doesn't really print anything that would be useful for debugging anyways, but `-vv` might. Rather than printing more likely-unnecessary information, just sequester it away to Talkative or higher verbosities.
…talkative-or-higher Print the Nix version when using `-vv` (or more) verbosity
…v1 case This speeds up re-importing a 15 GiB closure in version 1 of the nario format from 24.3s to 16.0s.
`StringSink` turns out to be pretty expensive if you have a bunch of very large strings, since once the string gets big, it's allocated outside of the regular heap via mmap. So every 4096 bytes we get a page fault, and the whole string is returned to the OS when `StringSink` is destroyed. So we have a huge system time overhead. So reuse the `StringSink` for each NAR. This speeds up importing a 15 GB NixOS system closure (with numerous large NARs) from 15.7s to 7.4s.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…tion nario v1 optimizations
Changes
```
git+file:///home/eelco/Dev/nix
├───checks
│ ├───aarch64-darwin
│ │ ├───installerScriptForGHA: omitted 'omitted (use '--all-systems' to show)'
...
└───nix-util-tests-stdenv: derivation 'package 'nix-util-tests-3.11.3''
```
to
```
git+file:///home/eelco/Dev/nix
├───checks
│ ├───aarch64-darwin
│ │ ├───installerScriptForGHA: omitted (use '--all-systems' to show)
...
└───nix-util-tests-stdenv: package 'nix-util-tests-3.11.3'
```
`skip()` can throw an exception, which we need to ignore since we may be unwinding an exception.
nix flake check: Fix output rendering
…c24-46a4-4a73-9085-0c3d57b8252b Release v3.12.0
…support-importing-result-of-fetchclosure Allow access to the result of fetchClosure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Not intended to be merged directly. This PR is a convenience to show the diff between upstream Nix and Determinate Nix (the
mainbranch).Continuation of #4.