Skip to content

Specify SDL version#726

Merged
tophyr merged 1 commit into
DescentDevelopers:mainfrom
tophyr:pr/specify-sdl-version
Jan 21, 2026
Merged

Specify SDL version#726
tophyr merged 1 commit into
DescentDevelopers:mainfrom
tophyr:pr/specify-sdl-version

Conversation

@tophyr
Copy link
Copy Markdown
Contributor

@tophyr tophyr commented Jan 21, 2026

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Both vcpkg.json and the ever-in-progress Android version rely on specific versions of SDL, so we should specify the version in CMake too.

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Both vcpkg.json and the ever-in-progress Android version rely on specific versions of SDL, so we should specify the version in CMake too.
@tophyr tophyr merged commit 566242d into DescentDevelopers:main Jan 21, 2026
8 checks passed
@tophyr tophyr deleted the pr/specify-sdl-version branch January 21, 2026 06:27
@Lgt2x
Copy link
Copy Markdown
Member

Lgt2x commented Jan 21, 2026

SDL 3.4 is out btw, may be worth updating

@tophyr
Copy link
Copy Markdown
Contributor Author

tophyr commented Jan 21, 2026

i briefly looked at it but i'm still trying to catch up to SDL2 -> SDL3 architectural changes lol

@Lgt2x
Copy link
Copy Markdown
Member

Lgt2x commented Jan 21, 2026

All good, I'll review #727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants