Skip to content

Conversation

@brandon-deploy
Copy link
Collaborator

@brandon-deploy brandon-deploy commented Jul 17, 2025

Fixes #4

Changes I have made:

  • Added product collections that can be requested through the API

I couldn't get the forms to conditionally hide. Though, my best attempt is still there within the UI component if anyone want to give it a shot.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@nathanchick
Copy link
Member

nathanchick commented Aug 19, 2025

Hey @brandon-deploy 👋 a couple of things I spotted:

  1. The category checkboxes in the conditions aren’t working — they’re throwing a JS error.
  2. The save button is redirecting back to the edit page. I traced this to the form-glue.js file, which seems to be adding the back param on submission. Nothing obvious jumped out, so might need a closer look.
  3. The visibility based on the “type” selection isn’t working. Again, nothing obvious in the code, but needs some digging.
  4. Removed Helper Class, probably the right thing to do, but there were many dependencies. I've quickly removed those so I could test the updates a little more. Please double-check that all is ok.

Copy link
Member

@nathanchick nathanchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^

@brandon-deploy
Copy link
Collaborator Author

Hi @nathanchick I have fixed the issues. The chooser (category id's form component thing) was expecting to be in a fieldset called rule_condition_fieldset due it being the same one from the catalog_rule module.

@brandon-deploy
Copy link
Collaborator Author

Hi @nathanchick, I've split the modules as requested. I've also fixed a few things.

As far as functionality goes, I think this is ready to go.

let me know if you spot anything your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Products Data

5 participants