-
Notifications
You must be signed in to change notification settings - Fork 1
Add product collections #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b57f185 to
47b1fb8
Compare
47b1fb8 to
50ba63c
Compare
src/BuilderIOProductCollections/Block/Adminhtml/ProductCollection/Edit/Tab/Conditions.php
Show resolved
Hide resolved
314cbe7 to
29b8d65
Compare
29b8d65 to
a9e2d37
Compare
a9e2d37 to
f22ec09
Compare
|
Hey @brandon-deploy 👋 a couple of things I spotted:
|
nathanchick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^^
|
Hi @nathanchick I have fixed the issues. The chooser (category id's form component thing) was expecting to be in a fieldset called rule_condition_fieldset due it being the same one from the catalog_rule module. |
I haven't tested this yet
|
Hi @nathanchick, I've split the modules as requested. I've also fixed a few things. As far as functionality goes, I think this is ready to go. let me know if you spot anything your side. |
Fixes #4
Changes I have made:
I couldn't get the forms to conditionally hide. Though, my best attempt is still there within the UI component if anyone want to give it a shot.
Contribution checklist