chore(brand): lowercase "dembrane" across user-facing strings#572
chore(brand): lowercase "dembrane" across user-facing strings#572spashii wants to merge 1 commit into
Conversation
Sweep: english UI strings (t``, <Trans>, alt, title), all 7 translation .po files (msgid + msgstr, incl. obsolete entries), recompiled .ts message bundles, asr hotwords in transcribe.py, "Dembrane Events" → "dembrane events" admin label in directus schema + sync snapshot, and the directus project_name setting. Leaves untouched (per requester clarification): - react component names (DembraneLogomark, DembraneLoadingSpinner, alwaysDembrane, useDembraneChat, LogoDembrane, etc.) - python identifiers, file paths, package metadata - internal pipeline ids (Dembrane-25-09, Dembrane-26-01-redaction) - the notion privacy-policy url slug - jinja prompt templates that quote "Dembrane" as the *incorrect* example - internal dev tools (tools/usage-tracker), readmes, cypress test docs - po path comments (#:) that reference real file paths Co-authored-by: Jorim Theuns <jorim@dembrane.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi ! Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
What
Brand sweep: lowercase "dembrane" wherever it appears as a user-facing brand reference, per
brand/STYLE_GUIDE.md(always lowercase, even at sentence start). Triggered by the QR portal welcome screen still showing "Welcome to Dembrane!" — extends the work in #547.Scope confirmed with Jorim in Slack (
C0B2VBYU79Vthread1778665562.741619):Changed
t\`,, JSX text,alt,<title>,useDocumentTitle`. ~12 .tsx/.ts/.html files..pofiles (de-DE,en-US,es-ES,fr-FR,it-IT,nl-NL,uk-UA):msgid+msgstrfor live entries, and#~-marked obsolete entries for consistency. Path-reference comments (#:) preserved..tsmessage bundles viapnpm messages:compile(ran withnode_modules/.bin/lingui compile --typescriptsince pnpm isn't in my sandbox).server/dembrane/transcribe.py(["Dembrane", "Sameer"]→["dembrane", "Sameer"])."Dembrane Events"→"dembrane events"choice label inscripts/create_schema.pyanddirectus/sync/snapshot/fields/workspace/legal_basis.json. Directusproject_namesetting → "dembrane".useOnboardingCards.ts(7 languages, including German caps as Jorim explicitly OK'd).Left alone (intentional)
DembraneLogomark,DembraneLoadingSpinner,LogoDembrane,alwaysDembrane,useDembraneChat,isDembraneKey,isDembraneUser,getDembraneEventsPrivacyCard.pyproject.tomlname = "Dembrane"), file paths.Dembrane-25-09,Dembrane-26-01-redaction,Dembrane-25-09-assemblyai-partial,Dembrane-Webhook/1.0user-agent.Privacy-Statement-Dembrane-…).agent/agent.pylines that quote"Dembrane"as the incorrect spelling to avoid..popath-reference comments (#:) pointing to component files likeDembraneLoadingSpinner/index.tsx.brand/STYLE_GUIDE.mdexample line showing the incorrect form.tools/usage-tracker/), READMEs,cypress/TEST_DOCUMENTATION.md."Dembrane"as a hotword string.Verification
tsc --noEmitonecho/frontend— clean.python3 -m py_compileon changed.pyfiles — clean.lingui compile --typescript— clean, no warnings, all .ts bundles have 0 capital "Dembrane".python3 -c 'import json; json.load(...)'on changed.jsonfiles — clean.Confidence
Medium-high. The mechanical replacement is straightforward and verified by grep/typecheck. Two areas to keep an eye on:
project_nameincollections/settings.json,"dembrane events"text choice). These are sync-snapshot files — applying them rewrites Directus settings. If the deploy pipeline syncs these automatically, the label change ships at deploy time. I haven't tested the Directus sync path. Question for review: is changingproject_namehere desired, or should this stay "Dembrane" for the admin context?.tsfiles: I ranlingui compilerather thanpnpm messages:compile, because pnpm isn't in my environment. The CLI should be equivalent (same binary), but if CI runs the pnpm-flavored script and the output drifts, this is where to look.Notes
msgids now match their (lowercased) source. No translator action needed.msgids inen-US.po(live + obsolete with same text) predate this PR — I didn't touch them beyond the casing change.lingui extract --cleanwould clean those up but rewrites 20k+ lines, so I left it for a separate PR.Originating Slack message: thread
1778665562.741619in#general(or whichever —C0B2VBYU79V).