ECHO-810 fix(participant): restore it-IT onboarding + italian a2 pass#571
Conversation
…2 pass Restore the it-IT entry in ParticipantOnboardingCards.tsx that was dropped in #529. Without it, the outer cards wrapper fell through to en-US even though useOnboardingCards.ts had the italian translations. Pass over the italian onboarding strings, privacy variants, and the existing it-IT.po entries: A2 reading level, informal "tu", sentence case for titles, active voice, lowercase "dembrane", short sentences. Add an Italian localization section to brand/STYLE_GUIDE.md mirroring the Dutch one — core rules, glossary, examples. Refs: ECHO-810 Co-authored-by: Sameer <sameer@dembrane.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (6)
Disabled knowledge base sources:
WalkthroughItalian localization rules and glossary are established in AGENTS.md and STYLE_GUIDE.md, then applied across ParticipantOnboardingCards component configuration, useOnboardingCards copy for onboarding and privacy card strings, and it-IT.po message translations. ChangesItalian Localization Guidelines and Strings
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi ! Thank you for contributing to Dembrane ECHO! Before we consider your Pull Request, we ask that you sign our Contributor License Agreement (CLA). This is only required for your first Pull Request. Please review the CLA, and sign it by adding your GitHub username to the contributors.yml file. Thanks! |
Summary
Two things in one PR — both anchored on the italian pilot:
Restore the
it-ITblock inParticipantOnboardingCards.tsx. The participant onboarding card wrapper has a hardcodedcardsobject that only listedde-DE/en-US/es-ES/fr-FR/nl-NLafter Qa fixes #529, so italian fell through to English even thoughuseOnboardingCards.tshad full italian translations underneath. Re-adds theit-ITentry. Onlyit-IT—uk-UAstays on en-US fallback as requested.Italian pass: A2-level + brand-aligned. Revised the italian onboarding strings (tutorial cards, "best practices", three privacy variants) and the existing translated entries in
it-IT.poagainst three rules:tu, neverLei/voidembrane, even at sentence startBrand guide. Added an
Italian localizationsection tobrand/STYLE_GUIDE.mdmirroring the Dutch one — core rules, glossary, good/bad examples. UpdatedAGENTS.mdto point at it. Added the italian A2 check to the pre-ship checklist.What changed
echo/frontend/src/components/participant/ParticipantOnboardingCards.tsx— restoreit-ITblock (microphone-check + "tutto pronto" sections)echo/frontend/src/components/participant/hooks/useOnboardingCards.ts— pass over italian: basic tutorial cards, advanced tutorial cards, "best practices" section, three privacy variants (client-managed / consent / legitimate-interest)echo/frontend/src/locales/it-IT.po— fixpiu→più, A2 polish on the 4 longer real translationsecho/frontend/src/locales/it-IT.ts— regenerated viapnpm messages:compileecho/brand/STYLE_GUIDE.md— newItalian localizationsection + checklist itemecho/AGENTS.md— pointer to the italian sectionCross-check
pnpm messages:compile→ onboarding cards now render in italian onportal.dembrane.com/it-IT/...pnpm exec biome checkclean on touched filespnpm exec tsc --noEmitcleanit-IT.tscompiled outputWhat I didn't touch
it-IT.postill has ~880 untranslated entries (en-US placeholders) and ~378 empty. Pauline's brief was "first information slides and portal instructions" — i scoped this PR to the onboarding cards + the already-translated entries. The remaining bulk-translation of the.pois a separate question (sameer to confirm scope).uk-UAonboarding cards block left on en-US fallback per instructions.echo-user-docssite — no italian content there. Same scoping question.Confidence
Medium. The bug fix part is mechanical and well-isolated (one file, additive, matches the pattern of the other locales). The translation pass is where the uncertainty sits: i can produce italian that reads naturally and follows the A2 + brand rules, but i'm not a native speaker — a native reviewer should sanity-check tone before this ships to the ActionAid pilot. Specific spots i'd flag for review:
"Acconsento alla registrazione e al trattamento..."→"Accetto che la mia conversazione sia registrata e trattata."— clearer but still affirmativeRefs: ECHO-810
Summary by CodeRabbit