This repository was archived by the owner on Jul 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Chat log (#52) #58
Open
Hun3431
wants to merge
16
commits into
develop
Choose a base branch
from
Chat_Log
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Chat log (#52) #58
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ae9dc8c
[Feat] ChatLogRequest DTO
Hun3431 e630dc1
[Feat] ChatLogResponse DTO
Hun3431 c7b311e
[Fix] ChatLogEntity DateTime type 수정
Hun3431 8e693e9
[Feat] ChatLog Controller
Hun3431 85f5b3c
[Feat] ChatLog Service
Hun3431 d246f03
[Fix] 오타수정
Hun3431 0b2ec15
[Fix] Remove ChatLog Response receiver
Hun3431 8365269
[Feat] ChatLog 리스트로 데이터 반환
Hun3431 b51026c
[Feat] 파라미터 roomId만으로 변경
Hun3431 ee54193
[Fix] Test를 위한 Authorize 제거
Hun3431 109c609
[Fix] 에러로 인한 동기 메서드 ToList() 로 변경
Hun3431 4e90501
Req DTO 주석 추가
Hun3431 bd6e17e
[Style] Auto dotnet format
yejun614 a8859a8
[Fix] Remove ChatLogRequest DTO
Hun3431 2b642f6
[Feat] ChatLog 인증 추가
Hun3431 07d280c
[Style] Auto dotnet format
yejun614 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| namespace server.DTOs; | ||
|
|
||
| public class ChatLogResponse | ||
| { | ||
| public long sender { get; set; } | ||
|
|
||
| public string message { get; set; } | ||
|
|
||
| public DateTime datetime { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
보안을 위한 작업이 추가로 필요할 것 같습니다.
만약에 RoomID가 탈취 되었을 경우 해당 채팅 방에서의 모든 채팅 기록을 받아볼 수 있을 가능성이 있어보입니다.
여러 방법이 있겠지만 JWT 인증을 통해 payload의 UserID(고유값)을 취하고 이를 Room 내 속해있는 유저인지 확인하는 작업이 추가되면 이를 개선할 수 있지 않을까 하는 제안을 해봅니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추석때 쉬라매!!!!!!!!!!!!!!!!!