Open
Conversation
Contributor
|
I think we can ignore the codeclimate offences |
tagliala
reviewed
Apr 17, 2020
MichalRemis
force-pushed
the
UseFieldSpecificWrappers
branch
from
d463fb0 to
1d5da93
Compare
Contributor
|
Please rebase on the current master, this PR is not clean If you have troubles in rebase, let me know Short-not-tested rebase guide Follow on screen instructions, then: After the rebase, I should not see anymore the following commits in this PR:
|
MichalRemis
force-pushed
the
UseFieldSpecificWrappers
branch
from
1d5da93 to
00950a5
Compare
Author
|
ok, rebased |
Contributor
|
@MichalRemis thanks! Now it looks good |
…y CSV Javascript form builder for adding/removing of error messages. Before CSV used only form-wide wrapper but field may use custom wrapper specified:
- by field's `wrapper` attribute
- by field's type and `wrapper_mappings` attribute
- by field's type and SimpleForm config `wrapper_mappings`
MichalRemis
force-pushed
the
UseFieldSpecificWrappers
branch
from
00950a5 to
3996907
Compare
tagliala
reviewed
Apr 28, 2020
| options.delete(:validate) | ||
| end | ||
|
|
||
| add_field_specific_wrapper_name_to_field_options(attribute_name, options, &block) |
Contributor
There was a problem hiding this comment.
Moving this to the parent gem will not be straightforward. I think I should add the method call to all the overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented field's specific wrapper_names to be passed to and used by CSV JS FormBuilder for adding/removing of error messages. Before CSV used only form-wide wrapper but SimpleForm's field may use custom wrapper specified:
wrapperattributewrapper_mappingsattributeSimpleForm.config.wrapper_mappingsI think this feature will be also required for implementation of validating of radios/dates/etc.
I am passing wrapper_name by input's
data-simple-form-wrapperattribute. Was thinking about putting it into CSV Hash, but I think it would require CSV code change and this is SimpleForm's thing anyway.