Strict Mode | MariaDB 10.2 Support#29
Open
ghost wants to merge 158 commits intoDavidJClark:masterfrom
Open
Conversation
Updated version of phpVMS 5.5.2 for php 7.2 compatibility
Move line 97 to above line 94
ln97 - DB::init(DBASE_TYPE);
ln94 - DB::$show_errors = Config::Get('DEBUG_MODE');
Update codon.config.php
changed ln108 - each() function deprecated
from
while (list($key, $value) = each(self::$values)) {
to
foreach(self::$values as $key => $value) {
Update Config.class.php
Add to define instance of countable if (is_array(PIREPData::getReportsByExportStatus(false)) || PIREPData::getReportsByExportStatus(false) instanceof Countable)
Update Dashboard.php
Make PIREP_PENDING array or object Add if (is_array(PIREPData::GetAllReportsByAccept(PIREP_PENDING)) || (PIREPData::GetAllReportsByAccept(PIREP_PENDING)) instanceof Countable)
Update sidebar_dashboard.php
Add before ln177 to make array or object if (is_array($allreports) || ($allreports) instanceof Countable)
Update PIREPAdmin.php
Deprecated each() changed to foreach()
foreach ($_POST as $name => $value) {
Update Settings.php
Changed ln40 - added ' to encase SKINS_PATH.DS.$filename; from $custom_path = SKINS_PATH.DS.$filename; to $custom_path = 'SKINS_PATH.DS.$filename';
Update TemplateDiffs.php
Update README.txt to reflect update for PHP 7.2 compatibility and possible need to install under PHP 5.6 for installation to success.
Warning: count(): Parameter must be an array or an object that implements Countable in C:\wamp64\www\phpvms_5.5.x-master\core\modules\Profile\Profile.php on line 200 Added if(is_array ($fields) || $fields instanceof Countable) before ln200
Warning: count(): Parameter must be an array or an object that implements Countable in C:\wamp64\www\phpvms_5.5.x-master\core\common\SchedulesData.class.php on line 804 This seems to only appear on initial start of Wamp and phpVMS from a fresh boot of computer. Will attempt fix with: if(is_array ($foo) || $foo instanceof Countable) -- placed before line 804 Added if(is_array($results) || $results intanceof Countable) before ln804
Update Profile.php
Update SchedulesData.class.php
Corrected spelling mistake on line 804
Code corrections for Countable
Spelling correction line 804 'instanceof'
Warning: count(): Parameter must be an array or an object that implements Countable in C:\wamp64\www\phpvms_5.5.x.72\core\modules\Registration\Registration.php on line 252 Added If(is_array($fields) || $fields instanceof Countable) before line 252
Warning: count(): Parameter must be an array or an object that implements Countable in C:\wamp64\www\phpvms_5.5.x.72\core\common\RegistrationData.class.php on line 138 Added if(is_array($fields) || $fields instanceof Countable) before line 138
Deprecated: __autoload() is deprecated, use spl_autoload_register() instead in C:\wamp64\www\phpvms_5.5.x.72\core\lib\phpmailer\PHPMailerAutoload.php on line 45 Commented out offending lines and added note as to why.
New Pilot Registration
New Pilot Registration
Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP; RSSFeed has a deprecated constructor in C:\wamp64\www\phpvms_5.5.x.72\core\common\RSSFeed.class.php on line 20 Even though the error shows line 20, you don't want to change the class - so you change the public function instead. Changed line 23 from public function RSSFeed to public function __construct
Moved closing bracket '}' to correct location
Changes to 'datetime' in several tables for MySQL 5.7
Changes to 'datetime' for My'SQL 5.7
Change 'date' for MySQL 5.7
Update install.sql
Update structure.xml
Update structure.xml
Removed php 7.3 for now
Admin error all pilots page/save changes #48 opened 3 hours ago by Capttuhd if(is_array($foo) || $foo instance of Countable) { ........ }
Added note about PHP 7.3+ incompatibility.
Add missing image file
Fixed "count" error in Admin when resetting PIREP count.
Added verbiage for "Strict Mode"
|
There is no reason to merge any Strict Mode commits that are being tested with phpVMS 5.5.2.72 into this archived phpVMS 5.5.2 repository. The Strict mode branch from phpVMS 5.5.2.72 was only for testing and had major issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, are you currently working on the MariaDB 10.2+ version? Or do you know when this will be published?
Greetings