Open
Conversation
… iceberg) and keeping track of all mutation tables in a database for backwards compatibility checking.
upgrade configuration.
Contributor
Author
|
@ferenc-csaky Apologies, this got a little beefy, but since I was already refactoring how we handle CREATE TABLE statements, I decided to also fix #1924. Need some help with the seedshop-avro test. How did that pass before with that This requires a 0.10.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves support for mutation tables, i.e. user defined
CREATE TABLEstatements that do not have a connector which means DataSQRL manages those tables and supports writing to and reading from those tables.This PR extends support by:
script.databaseconfig option in the package.json and - if such a file is present - we do a backwards compatibility check, failing the compilation in case of incompatibility.As we generalize mutation support for engines, we are making a requirement that a mutation table MUST have an
/*+engine(...)*/hint with the engine that this table is stored in (e.g. kafka, iceberg). This makes it less ambiguous which engine is used. It also makes it more compatible with Flink since newer versions of Flink allow tables without any connector configuration to be used as "schema" tables that are extended with LIKE. This is currently not possible with SQRL.Note, that this breaks backwards compatibility since existing SQRL implementations must add
/*+engine(kafka) */to mutation tables.This PR also introduces support for external catalogs and makes the import mechanism more robust.
It moves to Iceberg v3 format so we can use deletion vectors for efficiency.
Along the way, I encountered a number of bugs in how we handle mutation tables. Some are fixed in this PR and others have separate tickets: #1921.
Another improvement is in the iceberg connector configuration: moving to v3 and adding upsert.enabled for state tables.
This PR also implements a condensed version of the flink compiled plan which is easier to inspect than the comprehensive version. It is written to
flink-compiled-plan-summary.jsonand should be added as an asset to be captured by cloud-backend once this PR lands /cc @velo.