-
Notifications
You must be signed in to change notification settings - Fork 468
chore(writer): move forksafe hooks to writer #15458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 211 ± 3 ms. The average import time from base is: 212 ± 5 ms. The import time difference between this PR and base is: -1.0 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate vianney/fix-llmobs-flakyness (b1badab) with baseline main (701a90d) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.8% Memory: ✅ 40.058MB (SLO: <41.500MB -3.5%) vs baseline: +4.3% ✅ add_inplace_aspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.3% Memory: ✅ 40.234MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ add_inplace_noaspectTime: ✅ 0.320µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.2% Memory: ✅ 40.079MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ add_noaspectTime: ✅ 0.273µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -0.5% Memory: ✅ 40.263MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ bytearray_aspectTime: ✅ 1.362µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.2% Memory: ✅ 40.113MB (SLO: <41.500MB -3.3%) vs baseline: +3.5% ✅ bytearray_extend_aspectTime: ✅ 1.491µs (SLO: <10.000µs 📉 -85.1%) vs baseline: -0.8% Memory: ✅ 40.278MB (SLO: <41.500MB -2.9%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 0.619µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.7% Memory: ✅ 40.175MB (SLO: <41.500MB -3.2%) vs baseline: +4.1% ✅ bytearray_noaspectTime: ✅ 0.478µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.7% Memory: ✅ 40.197MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 1.295µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +0.7% Memory: ✅ 40.218MB (SLO: <41.500MB -3.1%) vs baseline: +4.0% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.6% Memory: ✅ 40.356MB (SLO: <41.500MB -2.8%) vs baseline: +4.8% ✅ bytesio_aspectTime: ✅ 1.342µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.5% Memory: ✅ 40.076MB (SLO: <41.500MB -3.4%) vs baseline: +3.6% ✅ bytesio_noaspectTime: ✅ 0.501µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.1% Memory: ✅ 40.317MB (SLO: <41.500MB -2.9%) vs baseline: +4.6% ✅ capitalize_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.5% Memory: ✅ 40.215MB (SLO: <41.500MB -3.1%) vs baseline: +3.8% ✅ capitalize_noaspectTime: ✅ 0.440µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +1.8% Memory: ✅ 40.097MB (SLO: <41.500MB -3.4%) vs baseline: +4.1% ✅ casefold_aspectTime: ✅ 0.733µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.5% Memory: ✅ 40.073MB (SLO: <41.500MB -3.4%) vs baseline: +3.5% ✅ casefold_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +2.3% Memory: ✅ 40.258MB (SLO: <41.500MB -3.0%) vs baseline: +4.5% ✅ decode_aspectTime: ✅ 0.725µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.0% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +3.7% ✅ decode_noaspectTime: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 40.158MB (SLO: <41.500MB -3.2%) vs baseline: +4.2% ✅ encode_aspectTime: ✅ 0.708µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.5% Memory: ✅ 40.073MB (SLO: <41.500MB -3.4%) vs baseline: +3.4% ✅ encode_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.9% Memory: ✅ 40.255MB (SLO: <41.500MB -3.0%) vs baseline: +4.5% ✅ format_aspectTime: ✅ 3.400µs (SLO: <10.000µs 📉 -66.0%) vs baseline: -0.8% Memory: ✅ 40.313MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 3.487µs (SLO: <10.000µs 📉 -65.1%) vs baseline: -2.9% Memory: ✅ 40.331MB (SLO: <41.500MB -2.8%) vs baseline: +4.2% ✅ format_map_noaspectTime: ✅ 0.774µs (SLO: <10.000µs 📉 -92.3%) vs baseline: +0.3% Memory: ✅ 40.157MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ format_noaspectTime: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: -1.3% Memory: ✅ 40.275MB (SLO: <41.500MB -3.0%) vs baseline: +4.3% ✅ index_aspectTime: ✅ 0.355µs (SLO: <10.000µs 📉 -96.5%) vs baseline: -1.0% Memory: ✅ 40.217MB (SLO: <41.500MB -3.1%) vs baseline: +4.3% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.7% Memory: ✅ 40.177MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ join_aspectTime: ✅ 1.355µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +2.1% Memory: ✅ 40.118MB (SLO: <41.500MB -3.3%) vs baseline: +4.2% ✅ join_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 40.198MB (SLO: <41.500MB -3.1%) vs baseline: +3.9% ✅ ljust_aspectTime: ✅ 2.593µs (SLO: <20.000µs 📉 -87.0%) vs baseline: +1.8% Memory: ✅ 40.132MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ ljust_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.4% Memory: ✅ 40.156MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ lower_aspectTime: ✅ 2.307µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +2.5% Memory: ✅ 40.093MB (SLO: <41.500MB -3.4%) vs baseline: +4.2% ✅ lower_noaspectTime: ✅ 0.365µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.5% Memory: ✅ 40.156MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 2.254µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.8% Memory: ✅ 40.134MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ lstrip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 40.157MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ modulo_aspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +3.6% Memory: ✅ 40.332MB (SLO: <41.500MB -2.8%) vs baseline: +4.3% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.546µs (SLO: <10.000µs 📉 -84.5%) vs baseline: ~same Memory: ✅ 40.178MB (SLO: <41.500MB -3.2%) vs baseline: +4.0% ✅ modulo_aspect_for_bytesTime: ✅ 0.972µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -0.3% Memory: ✅ 40.359MB (SLO: <41.500MB -2.7%) vs baseline: +5.3% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.254µs (SLO: <10.000µs 📉 -87.5%) vs baseline: +1.5% Memory: ✅ 40.359MB (SLO: <41.500MB -2.7%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.9% Memory: ✅ 40.156MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ replace_aspectTime: ✅ 4.860µs (SLO: <10.000µs 📉 -51.4%) vs baseline: -1.4% Memory: ✅ 40.075MB (SLO: <41.500MB -3.4%) vs baseline: +3.7% ✅ replace_noaspectTime: ✅ 0.466µs (SLO: <10.000µs 📉 -95.3%) vs baseline: +1.9% Memory: ✅ 40.219MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ repr_aspectTime: ✅ 0.902µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.8% Memory: ✅ 40.236MB (SLO: <41.500MB -3.0%) vs baseline: +4.3% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 40.200MB (SLO: <41.500MB -3.1%) vs baseline: +3.8% ✅ rstrip_aspectTime: ✅ 1.949µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +1.2% Memory: ✅ 40.273MB (SLO: <41.500MB -3.0%) vs baseline: +4.5% ✅ rstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.3% Memory: ✅ 40.296MB (SLO: <41.500MB -2.9%) vs baseline: +4.6% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2% Memory: ✅ 40.277MB (SLO: <41.500MB -2.9%) vs baseline: +4.5% ✅ slice_noaspectTime: ✅ 0.450µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.3% Memory: ✅ 40.296MB (SLO: <41.500MB -2.9%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 1.523µs (SLO: <10.000µs 📉 -84.8%) vs baseline: -1.0% Memory: ✅ 40.233MB (SLO: <41.500MB -3.1%) vs baseline: +4.1% ✅ stringio_noaspectTime: ✅ 0.715µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.2% Memory: ✅ 40.058MB (SLO: <41.500MB -3.5%) vs baseline: +4.0% ✅ strip_aspectTime: ✅ 2.247µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.0% Memory: ✅ 40.153MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.3% Memory: ✅ 40.116MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ swapcase_aspectTime: ✅ 2.761µs (SLO: <10.000µs 📉 -72.4%) vs baseline: 📈 +13.3% Memory: ✅ 40.313MB (SLO: <41.500MB -2.9%) vs baseline: +4.3% ✅ swapcase_noaspectTime: ✅ 0.540µs (SLO: <10.000µs 📉 -94.6%) vs baseline: ~same Memory: ✅ 40.217MB (SLO: <41.500MB -3.1%) vs baseline: +4.5% ✅ title_aspectTime: ✅ 2.424µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +2.1% Memory: ✅ 40.254MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.505µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 40.059MB (SLO: <41.500MB -3.5%) vs baseline: +4.0% ✅ translate_aspectTime: ✅ 3.315µs (SLO: <10.000µs 📉 -66.9%) vs baseline: +0.3% Memory: ✅ 40.195MB (SLO: <41.500MB -3.1%) vs baseline: +3.8% ✅ translate_noaspectTime: ✅ 1.041µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 40.178MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ upper_aspectTime: ✅ 2.315µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +3.2% Memory: ✅ 40.193MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ upper_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.6% Memory: ✅ 40.157MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.107µs (SLO: <10.000µs 📉 -48.9%) vs baseline: 📈 +24.0% Memory: ✅ 40.364MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 1.086µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.7% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.127µs (SLO: <10.000µs 📉 -38.7%) vs baseline: -1.4% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.3% ✅ ospathjoin_noaspectTime: ✅ 2.281µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.6% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.443µs (SLO: <10.000µs 📉 -65.6%) vs baseline: +0.5% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.567µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.6% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.3% ✅ ospathsplit_aspectTime: ✅ 4.707µs (SLO: <10.000µs 📉 -52.9%) vs baseline: -1.9% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +5.1% ✅ ospathsplit_noaspectTime: ✅ 1.605µs (SLO: <10.000µs 📉 -83.9%) vs baseline: +0.5% Memory: ✅ 40.423MB (SLO: <41.000MB 🟡 -1.4%) vs baseline: +5.3% ✅ ospathsplitdrive_aspectTime: ✅ 3.650µs (SLO: <10.000µs 📉 -63.5%) vs baseline: -0.8% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathsplitdrive_noaspectTime: ✅ 0.700µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.3% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.548µs (SLO: <10.000µs 📉 -54.5%) vs baseline: +0.7% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.390µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.4% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.3% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.396µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +13.6% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 200.533µs (SLO: <220.000µs -8.8%) vs baseline: -0.7% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.299µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -2.1% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +4.4% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.346µs (SLO: <230.000µs -5.9%) vs baseline: -0.9% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.155µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -4.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.762µs (SLO: <150.000µs -9.5%) vs baseline: -1.3% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.072µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -2.7% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.8% ✅ 1-rate-metrics-100-timesTime: ✅ 215.289µs (SLO: <250.000µs 📉 -13.9%) vs baseline: -0.7% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.503ms (SLO: <22.000ms -6.8%) vs baseline: -0.2% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.4% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.259ms (SLO: <2.300ms 🟡 -1.8%) vs baseline: -1.0% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +5.0% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.407ms (SLO: <1.550ms -9.2%) vs baseline: -0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.221ms (SLO: <2.550ms 📉 -12.9%) vs baseline: +0.6% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +4.4% ✅ flush-1-metricTime: ✅ 4.663µs (SLO: <20.000µs 📉 -76.7%) vs baseline: +2.5% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.893µs (SLO: <250.000µs 📉 -30.0%) vs baseline: +0.4% Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.2% ✅ flush-1000-metricsTime: ✅ 2.173ms (SLO: <2.500ms 📉 -13.1%) vs baseline: -0.9% Memory: ✅ 36.019MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +5.1% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
de4348a to
b634edd
Compare
68c0c25 to
22519a3
Compare
aa22e9d to
d768675
Compare
| ) -> None: | ||
| # FIXME: don't join() on stop(), let the caller handle this | ||
| super(NativeWriter, self)._stop_service() | ||
| forksafe.unregister_before_fork(self._fork_hook) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to unregister if the writer is GC'd, but not due to a fork? Or does it get automatically cleaned up?
Description
Move forksafe hooks to the writer, the goal is to make sure all native writer will execute the hook even ones not tied to the tracer. The fork hook is registered through a weakref to prevent it from blocking garbage collection of the writer.
Testing
Risks
Additional Notes