-
Notifications
You must be signed in to change notification settings - Fork 468
feat(ray): better handle the absence of ray.init() #15446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
e57d7ad to
fcae20e
Compare
fcae20e to
1848ea3
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 5 ms. The average import time from base is: 248 ± 3 ms. The import time difference between this PR and base is: 3.1 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate dubloom/ddtrace-run-ray (50301c6) with baseline main (f96a1dc) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.0% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 40.228MB (SLO: <41.500MB -3.1%) vs baseline: +3.7% ✅ add_inplace_noaspectTime: ✅ 0.323µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.7% Memory: ✅ 40.225MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ add_noaspectTime: ✅ 0.275µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +3.9% ✅ bytearray_aspectTime: ✅ 1.363µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +2.4% Memory: ✅ 40.164MB (SLO: <41.500MB -3.2%) vs baseline: +3.6% ✅ bytearray_extend_aspectTime: ✅ 1.515µs (SLO: <10.000µs 📉 -84.8%) vs baseline: +0.5% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +3.9% ✅ bytearray_extend_noaspectTime: ✅ 0.615µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.4% Memory: ✅ 40.245MB (SLO: <41.500MB -3.0%) vs baseline: +3.8% ✅ bytearray_noaspectTime: ✅ 0.480µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.5% Memory: ✅ 40.127MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 1.281µs (SLO: <10.000µs 📉 -87.2%) vs baseline: +0.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2% Memory: ✅ 40.166MB (SLO: <41.500MB -3.2%) vs baseline: +4.2% ✅ bytesio_aspectTime: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +2.1% Memory: ✅ 40.184MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ bytesio_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.4% Memory: ✅ 40.403MB (SLO: <41.500MB -2.6%) vs baseline: +5.1% ✅ capitalize_aspectTime: ✅ 0.742µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.5% Memory: ✅ 40.501MB (SLO: <41.500MB -2.4%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.437µs (SLO: <10.000µs 📉 -95.6%) vs baseline: +0.9% Memory: ✅ 40.166MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ casefold_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.6% Memory: ✅ 40.242MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ casefold_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.4% Memory: ✅ 40.363MB (SLO: <41.500MB -2.7%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.725µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.9% Memory: ✅ 40.541MB (SLO: <41.500MB -2.3%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 0.419µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.6% Memory: ✅ 40.442MB (SLO: <41.500MB -2.5%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.6% Memory: ✅ 40.600MB (SLO: <41.500MB -2.2%) vs baseline: +4.8% ✅ encode_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ format_aspectTime: ✅ 3.441µs (SLO: <10.000µs 📉 -65.6%) vs baseline: -0.8% Memory: ✅ 40.501MB (SLO: <41.500MB -2.4%) vs baseline: +5.3% ✅ format_map_aspectTime: ✅ 3.546µs (SLO: <10.000µs 📉 -64.5%) vs baseline: -3.5% Memory: ✅ 40.216MB (SLO: <41.500MB -3.1%) vs baseline: +3.9% ✅ format_map_noaspectTime: ✅ 0.773µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.3% Memory: ✅ 40.107MB (SLO: <41.500MB -3.4%) vs baseline: +4.2% ✅ format_noaspectTime: ✅ 0.596µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.4% Memory: ✅ 40.245MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 0.357µs (SLO: <10.000µs 📉 -96.4%) vs baseline: ~same Memory: ✅ 40.304MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.6% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.1% ✅ join_aspectTime: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.2% Memory: ✅ 40.127MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +3.9% ✅ ljust_aspectTime: ✅ 2.586µs (SLO: <20.000µs 📉 -87.1%) vs baseline: +2.0% Memory: ✅ 40.186MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: ~same Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 2.316µs (SLO: <10.000µs 📉 -76.8%) vs baseline: +2.6% Memory: ✅ 40.186MB (SLO: <41.500MB -3.2%) vs baseline: +3.6% ✅ lower_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.7% Memory: ✅ 40.304MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 2.273µs (SLO: <20.000µs 📉 -88.6%) vs baseline: +3.2% Memory: ✅ 40.462MB (SLO: <41.500MB -2.5%) vs baseline: +5.1% ✅ lstrip_noaspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.7% Memory: ✅ 40.186MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ modulo_aspectTime: ✅ 1.051µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +0.1% Memory: ✅ 40.521MB (SLO: <41.500MB -2.4%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.540µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.9% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.0% ✅ modulo_aspect_for_bytesTime: ✅ 0.985µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +1.1% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +3.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.242µs (SLO: <10.000µs 📉 -87.6%) vs baseline: ~same Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.4% Memory: ✅ 40.245MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 4.886µs (SLO: <10.000µs 📉 -51.1%) vs baseline: ~same Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +3.7% ✅ replace_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.9% Memory: ✅ 40.166MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ repr_aspectTime: ✅ 0.908µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.2% Memory: ✅ 40.225MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +1.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +3.7% ✅ rstrip_aspectTime: ✅ 1.949µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +1.5% Memory: ✅ 40.541MB (SLO: <41.500MB -2.3%) vs baseline: +5.2% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.5% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.2% Memory: ✅ 40.363MB (SLO: <41.500MB -2.7%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.6% Memory: ✅ 40.304MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 1.760µs (SLO: <10.000µs 📉 -82.4%) vs baseline: 📈 +13.9% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +3.9% ✅ stringio_noaspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.4% Memory: ✅ 40.185MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ strip_aspectTime: ✅ 2.250µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +2.2% Memory: ✅ 40.166MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ strip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.8% Memory: ✅ 40.225MB (SLO: <41.500MB -3.1%) vs baseline: +4.5% ✅ swapcase_aspectTime: ✅ 2.520µs (SLO: <10.000µs 📉 -74.8%) vs baseline: +3.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ swapcase_noaspectTime: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ title_aspectTime: ✅ 2.453µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +3.4% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +3.6% ✅ title_noaspectTime: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.1% Memory: ✅ 40.402MB (SLO: <41.500MB -2.6%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 3.336µs (SLO: <10.000µs 📉 -66.6%) vs baseline: +0.8% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +3.4% ✅ translate_noaspectTime: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.4% Memory: ✅ 40.284MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ upper_aspectTime: ✅ 2.314µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +3.3% Memory: ✅ 40.186MB (SLO: <41.500MB -3.2%) vs baseline: +3.9% ✅ upper_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 40.284MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.105µs (SLO: <10.000µs 📉 -48.9%) vs baseline: 📈 +23.9% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.074µs (SLO: <10.000µs 📉 -89.3%) vs baseline: -0.6% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.3% ✅ ospathjoin_aspectTime: ✅ 6.115µs (SLO: <10.000µs 📉 -38.8%) vs baseline: -0.4% Memory: ✅ 40.088MB (SLO: <41.000MB -2.2%) vs baseline: +4.3% ✅ ospathjoin_noaspectTime: ✅ 2.280µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.7% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.6% ✅ ospathnormcase_aspectTime: ✅ 3.424µs (SLO: <10.000µs 📉 -65.8%) vs baseline: +1.9% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.6% ✅ ospathnormcase_noaspectTime: ✅ 0.566µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.7% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.4% ✅ ospathsplit_aspectTime: ✅ 4.675µs (SLO: <10.000µs 📉 -53.3%) vs baseline: -2.0% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.4% ✅ ospathsplit_noaspectTime: ✅ 1.590µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.7% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 3.600µs (SLO: <10.000µs 📉 -64.0%) vs baseline: +1.0% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 0.690µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -1.9% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.6% ✅ ospathsplitext_aspectTime: ✅ 4.489µs (SLO: <10.000µs 📉 -55.1%) vs baseline: +0.8% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.395µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +16.1% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +4.2% ✅ 1-count-metrics-100-timesTime: ✅ 200.915µs (SLO: <220.000µs -8.7%) vs baseline: +0.6% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.309µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +1.6% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.4% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.047µs (SLO: <230.000µs -5.6%) vs baseline: +1.4% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 1-gauge-metric-1-timesTime: ✅ 2.156µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.534µs (SLO: <150.000µs -9.0%) vs baseline: +0.1% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.057µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -0.2% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ 1-rate-metrics-100-timesTime: ✅ 215.496µs (SLO: <250.000µs 📉 -13.8%) vs baseline: +1.1% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.543ms (SLO: <22.000ms -6.6%) vs baseline: +1.0% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.299ms (SLO: <2.300ms 🟡 ~same) vs baseline: +2.8% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +3.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: +1.0% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.3% ✅ 100-rate-metrics-100-timesTime: ✅ 2.235ms (SLO: <2.550ms 📉 -12.4%) vs baseline: +1.9% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.4% ✅ flush-1-metricTime: ✅ 4.565µs (SLO: <20.000µs 📉 -77.2%) vs baseline: +2.2% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 174.458µs (SLO: <250.000µs 📉 -30.2%) vs baseline: ~same Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.4% ✅ flush-1000-metricsTime: ✅ 2.203ms (SLO: <2.500ms 📉 -11.9%) vs baseline: +0.5% Memory: ✅ 36.019MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +5.0% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Testing
Risks
Additional Notes