-
Notifications
You must be signed in to change notification settings - Fork 467
chore(codeowners): assign contrib, test, and snapshot files apm-serverless codeowner #14795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Co-authored-by: Brett Langdon <[email protected]>
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 240 ± 3 ms. The average import time from base is: 248 ± 4 ms. The import time difference between this PR and base is: -7.2 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate duncan-harvey/apm-serverless-codeowners (f511074) with baseline main (7847737) 📈 Performance Regressions (2 suites)📈 iast_aspects - 40/40✅ re_expand_aspectTime: ✅ 31.907µs (SLO: <40.000µs 📉 -20.2%) vs baseline: ~same Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ re_expand_noaspectTime: ✅ 29.985µs (SLO: <40.000µs 📉 -25.0%) vs baseline: +4.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ re_findall_aspectTime: ✅ 2.927µs (SLO: <10.000µs 📉 -70.7%) vs baseline: +0.1% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ re_findall_noaspectTime: ✅ 1.442µs (SLO: <10.000µs 📉 -85.6%) vs baseline: +2.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ re_finditer_aspectTime: ✅ 4.496µs (SLO: <10.000µs 📉 -55.0%) vs baseline: +0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.8% ✅ re_finditer_noaspectTime: ✅ 1.411µs (SLO: <10.000µs 📉 -85.9%) vs baseline: -0.5% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ re_fullmatch_aspectTime: ✅ 2.694µs (SLO: <10.000µs 📉 -73.1%) vs baseline: -0.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ re_fullmatch_noaspectTime: ✅ 1.306µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +1.0% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ re_group_aspectTime: ✅ 2.953µs (SLO: <10.000µs 📉 -70.5%) vs baseline: +0.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_group_noaspectTime: ✅ 1.616µs (SLO: <10.000µs 📉 -83.8%) vs baseline: +1.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.9% ✅ re_groups_aspectTime: ✅ 3.092µs (SLO: <10.000µs 📉 -69.1%) vs baseline: +0.3% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.7% ✅ re_groups_noaspectTime: ✅ 1.706µs (SLO: <10.000µs 📉 -82.9%) vs baseline: +0.5% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_match_aspectTime: ✅ 3.095µs (SLO: <10.000µs 📉 -69.1%) vs baseline: 📈 +13.3% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ re_match_noaspectTime: ✅ 1.305µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +0.4% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ re_search_aspectTime: ✅ 2.586µs (SLO: <10.000µs 📉 -74.1%) vs baseline: +0.6% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ re_search_noaspectTime: ✅ 1.204µs (SLO: <10.000µs 📉 -88.0%) vs baseline: +0.1% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ re_sub_aspectTime: ✅ 3.445µs (SLO: <10.000µs 📉 -65.6%) vs baseline: -0.2% Memory: ✅ 37.650MB (SLO: <39.000MB -3.5%) vs baseline: +4.9% ✅ re_sub_noaspectTime: ✅ 1.533µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +0.5% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.1% ✅ re_subn_aspectTime: ✅ 3.671µs (SLO: <10.000µs 📉 -63.3%) vs baseline: +0.6% Memory: ✅ 37.729MB (SLO: <39.000MB -3.3%) vs baseline: +5.3% ✅ re_subn_noaspectTime: ✅ 1.636µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +1.7% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.113µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.8% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 213.580µs (SLO: <250.000µs 📉 -14.6%) vs baseline: -0.2% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 2.929µs (SLO: <20.000µs 📉 -85.4%) vs baseline: +0.2% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 192.382µs (SLO: <220.000µs 📉 -12.6%) vs baseline: +0.6% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.322µs (SLO: <20.000µs 📉 -88.4%) vs baseline: 📈 +12.5% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 125.577µs (SLO: <150.000µs 📉 -16.3%) vs baseline: +0.5% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.093µs (SLO: <20.000µs 📉 -84.5%) vs baseline: -1.1% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 214.581µs (SLO: <250.000µs 📉 -14.2%) vs baseline: +0.5% Memory: ✅ 32.224MB (SLO: <34.000MB -5.2%) vs baseline: +5.2% ✅ 100-count-metrics-100-timesTime: ✅ 21.578ms (SLO: <23.500ms -8.2%) vs baseline: +1.2% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 1.967ms (SLO: <2.250ms 📉 -12.6%) vs baseline: -1.1% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.290ms (SLO: <1.550ms 📉 -16.8%) vs baseline: +0.9% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.200ms (SLO: <2.550ms 📉 -13.7%) vs baseline: +0.7% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.690µs (SLO: <20.000µs 📉 -76.5%) vs baseline: +9.0% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 181.070µs (SLO: <250.000µs 📉 -27.6%) vs baseline: -0.4% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.230ms (SLO: <2.500ms 📉 -10.8%) vs baseline: +0.8% Memory: ✅ 32.912MB (SLO: <34.500MB -4.6%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.483ms (SLO: <22.300ms -8.1%) vs baseline: -0.2% Memory: ✅ 65.410MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.350ms (SLO: <1.450ms -6.9%) vs baseline: -0.3% Memory: ✅ 64.603MB (SLO: <67.000MB -3.6%) vs baseline: +4.8% ✅ iastTime: ✅ 20.460ms (SLO: <22.250ms -8.0%) vs baseline: -0.3% Memory: ✅ 65.417MB (SLO: <67.000MB -2.4%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.316ms (SLO: <16.550ms -7.5%) vs baseline: +0.3% Memory: ✅ 53.654MB (SLO: <54.500MB 🟡 -1.6%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 20.524ms (SLO: <21.750ms -5.6%) vs baseline: -0.4% Memory: ✅ 65.429MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 26.119ms (SLO: <28.200ms -7.4%) vs baseline: -0.6% Memory: ✅ 67.627MB (SLO: <69.500MB -2.7%) vs baseline: +4.8% ✅ tracerTime: ✅ 20.462ms (SLO: <21.750ms -5.9%) vs baseline: ~same Memory: ✅ 65.438MB (SLO: <67.000MB -2.3%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.024ms (SLO: <23.500ms -6.3%) vs baseline: -0.4% Memory: ✅ 66.656MB (SLO: <67.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.318ms (SLO: <21.500ms 📉 -10.1%) vs baseline: -0.3% Memory: ✅ 65.447MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.654ms (SLO: <17.500ms -4.8%) vs baseline: +0.3% Memory: ✅ 65.481MB (SLO: <66.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.466ms (SLO: <21.750ms -5.9%) vs baseline: -0.3% Memory: ✅ 71.413MB (SLO: <72.500MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.472ms (SLO: <19.650ms -6.0%) vs baseline: +0.1% Memory: ✅ 65.453MB (SLO: <67.000MB -2.3%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.845ms (SLO: <20.100ms -6.2%) vs baseline: +0.2% Memory: ✅ 65.362MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.181ms (SLO: <21.500ms -6.1%) vs baseline: ~same Memory: ✅ 65.478MB (SLO: <67.000MB -2.3%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.323ms (SLO: <22.000ms -7.6%) vs baseline: ~same Memory: ✅ 65.410MB (SLO: <67.000MB -2.4%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 17.976ms (SLO: <19.850ms -9.4%) vs baseline: -0.4% Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.179ms (SLO: <19.400ms -6.3%) vs baseline: +0.6% Memory: ✅ 65.291MB (SLO: <66.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.118ms (SLO: <19.450ms -6.8%) vs baseline: +0.4% Memory: ✅ 65.215MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.575ms (SLO: <4.750ms -3.7%) vs baseline: ~same Memory: ✅ 62.010MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.590ms (SLO: <6.750ms -2.4%) vs baseline: +0.3% Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.1% ✅ appsec-telemetryTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: +0.3% Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 45.495MB (SLO: <47.000MB -3.2%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.864ms (SLO: <2.000ms -6.8%) vs baseline: +0.3% Memory: ✅ 42.389MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +5.0% ✅ profilerTime: ✅ 1.914ms (SLO: <2.100ms -8.8%) vs baseline: +0.2% Memory: ✅ 46.498MB (SLO: <47.000MB 🟡 -1.1%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.385ms (SLO: <3.650ms -7.2%) vs baseline: +0.2% Memory: ✅ 52.199MB (SLO: <53.500MB -2.4%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.371ms (SLO: <3.650ms -7.6%) vs baseline: -0.1% Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +5.0% ✅ tracer-nativeTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: ~same Memory: ✅ 58.228MB (SLO: <60.000MB -3.0%) vs baseline: +4.6% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 42.498ms (SLO: <47.150ms -9.9%) vs baseline: +0.3% Memory: ✅ 44.406MB (SLO: <47.000MB -5.5%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 319.167ms (SLO: <344.800ms -7.4%) vs baseline: +1.0% Memory: ✅ 595.407MB (SLO: <600.000MB 🟡 -0.8%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 287.407ms (SLO: <314.000ms -8.5%) vs baseline: +0.1% Memory: ✅ 596.471MB (SLO: <600.000MB 🟡 -0.6%) vs baseline: +4.8% ✅ get-contextTime: ✅ 80.745ms (SLO: <92.350ms 📉 -12.6%) vs baseline: +0.3% Memory: ✅ 39.994MB (SLO: <46.500MB 📉 -14.0%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 38.970ms (SLO: <44.500ms 📉 -12.4%) vs baseline: +0.3% Memory: ✅ 43.938MB (SLO: <47.500MB -7.5%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 58.938ms (SLO: <67.650ms 📉 -12.9%) vs baseline: ~same Memory: ✅ 40.214MB (SLO: <47.000MB 📉 -14.4%) vs baseline: +4.9% ✅ set-statusTime: ✅ 44.809ms (SLO: <50.400ms 📉 -11.1%) vs baseline: +0.2% Memory: ✅ 43.837MB (SLO: <47.000MB -6.7%) vs baseline: +4.5% ✅ startTime: ✅ 38.038ms (SLO: <43.450ms 📉 -12.5%) vs baseline: -0.4% Memory: ✅ 43.920MB (SLO: <47.000MB -6.6%) vs baseline: +4.8% ✅ start-finishTime: ✅ 83.122ms (SLO: <88.000ms -5.5%) vs baseline: +0.7% Memory: ✅ 34.564MB (SLO: <46.500MB 📉 -25.7%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 84.171ms (SLO: <89.000ms -5.4%) vs baseline: +0.5% Memory: ✅ 34.524MB (SLO: <46.500MB 📉 -25.8%) vs baseline: +4.9% ✅ update-nameTime: ✅ 40.168ms (SLO: <45.150ms 📉 -11.0%) vs baseline: +0.4% Memory: ✅ 44.281MB (SLO: <47.000MB -5.8%) vs baseline: +4.9% 🟡 span - 26/26✅ add-eventTime: ✅ 20.790ms (SLO: <22.500ms -7.6%) vs baseline: +1.4% Memory: ✅ 50.343MB (SLO: <53.000MB -5.0%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 91.511ms (SLO: <93.500ms -2.1%) vs baseline: +0.5% Memory: ✅ 660.816MB (SLO: <961.000MB 📉 -31.2%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 147.813ms (SLO: <155.000ms -4.6%) vs baseline: +0.5% Memory: ✅ 661.420MB (SLO: <962.500MB 📉 -31.3%) vs baseline: +4.8% ✅ get-contextTime: ✅ 19.378ms (SLO: <20.500ms -5.5%) vs baseline: +0.4% Memory: ✅ 49.182MB (SLO: <53.000MB -7.2%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 19.631ms (SLO: <20.500ms -4.2%) vs baseline: +0.5% Memory: ✅ 49.197MB (SLO: <53.000MB -7.2%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 38.561ms (SLO: <40.000ms -3.6%) vs baseline: +1.0% Memory: ✅ 42.770MB (SLO: <53.000MB 📉 -19.3%) vs baseline: +4.8% ✅ set-statusTime: ✅ 21.342ms (SLO: <22.000ms -3.0%) vs baseline: +0.7% Memory: ✅ 49.252MB (SLO: <53.000MB -7.1%) vs baseline: +5.1% ✅ startTime: ✅ 19.309ms (SLO: <20.500ms -5.8%) vs baseline: +0.5% Memory: ✅ 49.186MB (SLO: <53.000MB -7.2%) vs baseline: +5.0% ✅ start-finishTime: ✅ 51.451ms (SLO: <52.500ms 🟡 -2.0%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 52.916ms (SLO: <54.500ms -2.9%) vs baseline: +0.3% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ start-finish-traceid128Time: ✅ 55.071ms (SLO: <56.000ms 🟡 -1.7%) vs baseline: +0.7% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ start-traceid128Time: ✅ 19.825ms (SLO: <22.500ms 📉 -11.9%) vs baseline: +1.1% Memory: ✅ 49.095MB (SLO: <53.000MB -7.4%) vs baseline: +4.9% ✅ update-nameTime: ✅ 20.158ms (SLO: <22.000ms -8.4%) vs baseline: ~same Memory: ✅ 49.770MB (SLO: <53.000MB -6.1%) vs baseline: +4.8%
|
Description
Add codeowners for files that should be reviewed by
apm-serverless. Also addserverlessas a codeowner temporarily whileapm-serverlessgets up to speed on supporting the Azure Integrations.Testing
Risks
Additional Notes
Relevant integrations owned by apm-serverless