Skip to content

RUM-11445: Fix detekt InvalidStringFormat false alarms#3278

Open
kikoveiga wants to merge 1 commit intodevelopfrom
kikoveiga/RUM-11445/invalid-string-format
Open

RUM-11445: Fix detekt InvalidStringFormat false alarms#3278
kikoveiga wants to merge 1 commit intodevelopfrom
kikoveiga/RUM-11445/invalid-string-format

Conversation

@kikoveiga
Copy link
Contributor

@kikoveiga kikoveiga commented Mar 20, 2026

What does this PR do?

  • Fix InvalidStringFormat false positives by adding transitive module dependencies to the custom detekt rule's classpath.
  • Add PackageQualifier handling in ReceiverExt to eliminate Unknown receiver type warnings.
  • Fix local_ci.sh early exit.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga kikoveiga self-assigned this Mar 20, 2026
@kikoveiga kikoveiga force-pushed the kikoveiga/RUM-11445/invalid-string-format branch from 8ba4402 to 9d26d15 Compare March 20, 2026 17:09
@datadog-prod-us1-6

This comment has been minimized.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.45%. Comparing base (61409f2) to head (9d26d15).

Files with missing lines Patch % Lines
...android/trace/internal/DatadogPropagationHelper.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3278      +/-   ##
===========================================
- Coverage    71.68%   71.45%   -0.23%     
===========================================
  Files          942      942              
  Lines        34811    34811              
  Branches      5899     5899              
===========================================
- Hits         24954    24873      -81     
- Misses        8233     8280      +47     
- Partials      1624     1658      +34     
Files with missing lines Coverage Δ
...datadog/android/okhttp/trace/TracingInterceptor.kt 81.94% <ø> (ø)
...android/trace/internal/DatadogPropagationHelper.kt 66.46% <0.00%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga marked this pull request as ready for review March 20, 2026 18:30
@kikoveiga kikoveiga requested review from a team as code owners March 20, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants