nodejs/node#55116 #15
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| ch.unsubscribe = function () { | ||
| // TODO: update me | ||
| this._subscribers = ArrayPrototypeSlice(this._subscribers); | ||
|
|
||
| return subscribe.apply(this, arguments); | ||
| }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected unnamed function. (...read more)
It is easier to debug your application code when you avoid anonymous functions so that the stack trace can show you meaningful error messages. This rule enforces all your function to be consistently declared with a name.
| dc.channel = function () { | ||
| const ch = dc_channel.apply(this, arguments); | ||
|
|
||
| if (channels.has(ch)) return ch; | ||
|
|
||
| const { subscribe, unsubscribe, publish } = ch; | ||
|
|
||
| ch.subscribe = function () { | ||
| this._subscribers = ArrayPrototypeSlice(this._subscribers); | ||
|
|
||
| return subscribe.apply(this, arguments); | ||
| }; | ||
|
|
||
| ch.unsubscribe = function () { | ||
| // TODO: update me | ||
| this._subscribers = ArrayPrototypeSlice(this._subscribers); | ||
|
|
||
| return subscribe.apply(this, arguments); | ||
| }; | ||
|
|
||
| ch.publish = function () { | ||
| const self = Object.assign({}, this); | ||
|
|
||
| return publish.apply(self, arguments) | ||
| }; | ||
|
|
||
| channels.add(ch); | ||
|
|
||
| return ch; | ||
| }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected unnamed function. (...read more)
It is easier to debug your application code when you avoid anonymous functions so that the stack trace can show you meaningful error messages. This rule enforces all your function to be consistently declared with a name.
| module.exports = function (unpatched) { | ||
| const channels = new WeakSet(); | ||
|
|
||
| const dc_channel = unpatched.channel; | ||
|
|
||
| const dc = { ...unpatched }; | ||
|
|
||
| dc.channel = function () { | ||
| const ch = dc_channel.apply(this, arguments); | ||
|
|
||
| if (channels.has(ch)) return ch; | ||
|
|
||
| const { subscribe, unsubscribe, publish } = ch; | ||
|
|
||
| ch.subscribe = function () { | ||
| this._subscribers = ArrayPrototypeSlice(this._subscribers); | ||
|
|
||
| return subscribe.apply(this, arguments); | ||
| }; | ||
|
|
||
| ch.unsubscribe = function () { | ||
| // TODO: update me | ||
| this._subscribers = ArrayPrototypeSlice(this._subscribers); | ||
|
|
||
| return subscribe.apply(this, arguments); | ||
| }; | ||
|
|
||
| ch.publish = function () { | ||
| const self = Object.assign({}, this); | ||
|
|
||
| return publish.apply(self, arguments) | ||
| }; | ||
|
|
||
| channels.add(ch); | ||
|
|
||
| return ch; | ||
| }; | ||
|
|
||
| return dc; | ||
| }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Unexpected unnamed function. (...read more)
It is easier to debug your application code when you avoid anonymous functions so that the stack trace can show you meaningful error messages. This rule enforces all your function to be consistently declared with a name.
Add polyfill for a bugfix in node core: nodejs/node#55116