Add path parameter support for undo operations in v2 #3333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BDD test undo operations previously could only extract parameters from response bodies or request bodies. This prevented proper cleanup of resources where identifiers exist only in the request URL path. This adds support for origin: "path" in undo.json definitions, allowing undo operations to reference path parameters from the original request. - Added pathParameters field to World class - Modified buildUndoFor to accept and handle path parameters - Updated step definitions to pass path parameters during request setup Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
origin: "path"in undo.json definitions, allowing BDD test undo operations to reference path parameters from the original request URL.This aligns the TypeScript v2 client with implementations already done in:
Problem
BDD test undo operations could only extract parameters from response bodies or request bodies. This prevented proper cleanup of resources where identifiers exist only in the request URL path (e.g.,
POST /integrations/{integration_name}/accounts).Changes
1.
private/bdd_runner/src/support/world.tspathParametersfield to World class to track path parameters2.
private/bdd_runner/src/support/undo.tsbuildUndoForfunction signature to acceptpathParametersparameterorigin: "path"following the same pattern as other origins3.
private/bdd_runner/src/step_definitions/request_steps.tsbuildUndoForcall to passthis.optsas pathParameters (contains all request parameters including path ones)Test Plan
🤖 Generated with Claude Code