fix path parameter dont serialize #3129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nogates
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
BDD test undo operations fail when path parameters are needed because the values stored in
path_parametersare double-serialized. The undo mechanism expects raw values, not JSON strings.Changes
request_parameterfunction intests/conftest.pyvalue = glom(context, path)path_parametersfor undo operations (with both original and snake_case naming)context["api_request"]["kwargs"][param_name] = json.dumps(value)Tests
Run BDD tests that use fixtures with path parameters (on top of the changes generated by https://github.com/DataDog/datadog-api-spec/pull/4875).** Verify undo operations execute successfully without serialization errors.