Skip to content

[ABLD-8] Package security-agent and APM hands-off example configs via Bazel - #55915

Open
aiuto wants to merge 5 commits into
mainfrom
aiuto/abld8-config-exports
Open

[ABLD-8] Package security-agent and APM hands-off example configs via Bazel#55915
aiuto wants to merge 5 commits into
mainfrom
aiuto/abld8-config-exports

Conversation

@aiuto

@aiuto aiuto commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

What this does

  • make example configs from /pkg/config part of the bazel packaging scheme
  • removes their distinct handling in datadog-agent.rb.

Testing

CI. If this were not correct, the file diff test on the .deb package would have failed.

Exposes security-agent.yaml.example and application_monitoring.yaml.example
as file targets so packages/agent/product can package them directly instead
of via omnibus copy/move commands.
@aiuto aiuto added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Sep 6, 2026
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/fleet-automation labels Sep 6, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Sep 6, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

The patch is correct. Both exported files exist within the Bazel package, and exports_files makes them available to other packages. No actionable issues found; this change does not alter runtime behavior. Validation was limited to static inspection.

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.63% (+5.29%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 75aba88 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor ae645b2f:

Results for datadog-agent_7.85.0~devel.git.33.75aba88.pipeline.135738726-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.85.0~devel.git.33.75aba88.pipeline.135738726-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ae645b2
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 780.310 MiB
agent_deb_amd64_fips 715.111 MiB
agent_heroku_amd64 316.152 MiB
agent_msi 648.386 MiB
agent_rpm_amd64 780.294 MiB
agent_rpm_amd64_fips 715.095 MiB
agent_rpm_arm64 751.263 MiB
agent_rpm_arm64_fips 691.585 MiB
agent_suse_amd64 780.294 MiB
agent_suse_amd64_fips 715.095 MiB
agent_suse_arm64 751.263 MiB
agent_suse_arm64_fips 691.585 MiB
docker_agent_amd64 839.249 MiB
docker_agent_arm64 835.297 MiB
docker_agent_jmx_amd64 1030.161 MiB
docker_agent_jmx_arm64 1014.989 MiB
docker_cluster_agent_amd64 212.725 MiB
docker_cluster_agent_arm64 225.780 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.557 MiB
docker_dogstatsd_arm64 37.686 MiB
docker_host_profiler_amd64 307.579 MiB
docker_host_profiler_arm64 318.792 MiB
dogstatsd_deb_amd64 30.303 MiB
dogstatsd_deb_arm64 28.315 MiB
dogstatsd_rpm_amd64 30.303 MiB
dogstatsd_suse_amd64 30.303 MiB
iot_agent_deb_amd64 46.659 MiB
iot_agent_deb_arm64 43.284 MiB
iot_agent_deb_armhf 44.097 MiB
iot_agent_rpm_amd64 46.659 MiB
iot_agent_suse_amd64 46.658 MiB

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 6, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 2562902b-e215-4bc8-88d1-cedb8a1c405d

Baseline: f98a88d
Comparison: 75aba88
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization +3.13 [+2.89, +3.38] 1 Logs
quality_gate_idle_all_features memory utilization +0.22 [+0.18, +0.25] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.13 [+0.10, +0.16] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.13 [+0.08, +0.17] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.13 [+0.07, +0.19] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.02 [-0.25, +0.22] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization -0.02 [-0.24, +0.20] 1 Logs
quality_gate_security_no_fs_load memory utilization -0.08 [-0.15, -0.01] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.28 [-0.41, -0.16] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.36 [-1.22, +0.49] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.76MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 746.29KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 523.29MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 215.01MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.52MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 366.65 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 20 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 433.03MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.42MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 28.44 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 328.97MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 67.05 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 308.25MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 24.32 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 308.82MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

… Bazel

Uses filegroup targets in pkg/config/BUILD.bazel (instead of exports_files)
to expose security-agent.yaml.example and application_monitoring.yaml.example,
adds pkg_files targets for them in packages/agent/product (skipped on heroku
and macos/windows respectively), and drops the now-redundant move/copy calls
from omnibus/config/software/datadog-agent.rb.
@aiuto aiuto changed the title [ABLD-8] Export static example config files from pkg/config [ABLD-8] Package security-agent and APM hands-off example configs via Bazel Sep 6, 2026
security-agent.yaml.example and application_monitoring.yaml.example ship
alongside datadog.yaml.example, so package them via the same pkg_files
target instead of two separate ones with identical prefixes.
@aiuto
aiuto marked this pull request as ready for review September 6, 2026 17:19
@aiuto
aiuto requested review from a team as code owners September 6, 2026 17:19
@aiuto
aiuto requested a review from oleroydatadog September 6, 2026 17:19

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

The patch is correct. The Bazel mappings preserve the existing platform and Heroku conditions and install destinations. No actionable issues found. Package builds were not run in the read-only environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build team/fleet-automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant