Skip to content

fix docker_build_fips_agent7_jmx - #55914

Merged
Ishirui merged 1 commit into
mainfrom
aiuto/fix_jmx
Sep 6, 2026
Merged

fix docker_build_fips_agent7_jmx#55914
Ishirui merged 1 commit into
mainfrom
aiuto/fix_jmx

Conversation

@aiuto

@aiuto aiuto commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

This fixes broken CI on main. If you approve it, please also merge immediately.

Apologies for the verbose PR description. Claude wrote it.
I looked at the code and it makes sense with the comments added.

what this does
Fixes the docker_build_fips_agent7_jmx CI job, which has been failing on
main since #55906 with crane flatten erroring "verifying layer: invalid
input: magic number mismatch" during layer upload.

The apt-mirror content change in #55906 invalidated the registry build
cache for the baseimage layer repo-wide, forcing every job to
repopulate its cache. BuildKit's registry cache exporter can store cache
blobs as zstd; when a later build reuses such a blob as-is under the
oci-mediatypes=false flag (which forces Docker-schema, gzip-only media
types on the final push), the layer ends up with content that doesn't
match its declared media type. crane flatten's registry verification
then rejects the mismatched blob. This surfaced specifically on the
FIPS+JMX amd64 flavor's flatten step.

Adds compression=gzip,force-compression=true to both the cache export
(--cache-to) and the final image export (docker buildx build --output=...) so every layer -- including ones reused from cache -- is
always re-encoded as gzip, matching the Docker media types already
forced for #incident-59848. This does not touch or revert the apt-mirror
change from #55906.

testing
Change is CI-config only; verified via docker_linux.yml diff review
and by correlating Datadog CI Visibility job/log data to isolate the
crane flatten failure to the cache/media-type-mismatch mechanism
described above.

next steps
Watch the docker_build_fips_agent7_jmx (and arm64/non-FIPS variants) job
on this branch's pipeline to confirm the fix resolves the failure.

**what this does**
Fixes the docker_build_fips_agent7_jmx CI job, which has been failing on
main since #55906 with `crane flatten` erroring "verifying layer: invalid
input: magic number mismatch" during layer upload.

The apt-mirror content change in #55906 invalidated the registry build
cache for the `baseimage` layer repo-wide, forcing every job to
repopulate its cache. BuildKit's registry cache exporter can store cache
blobs as zstd; when a later build reuses such a blob as-is under the
`oci-mediatypes=false` flag (which forces Docker-schema, gzip-only media
types on the final push), the layer ends up with content that doesn't
match its declared media type. `crane flatten`'s registry verification
then rejects the mismatched blob. This surfaced specifically on the
FIPS+JMX amd64 flavor's flatten step.

Adds `compression=gzip,force-compression=true` to both the cache export
(`--cache-to`) and the final image export (`docker buildx build
--output=...`) so every layer -- including ones reused from cache -- is
always re-encoded as gzip, matching the Docker media types already
forced for #incident-59848. This does not touch or revert the apt-mirror
change from #55906.

**testing**
Change is CI-config only; verified via `docker_linux.yml` diff review
and by correlating Datadog CI Visibility job/log data to isolate the
`crane flatten` failure to the cache/media-type-mismatch mechanism
described above. Will confirm against a live pipeline run on this branch.

**next steps**
Watch the docker_build_fips_agent7_jmx (and arm64/non-FIPS variants) job
on this branch's pipeline to confirm the fix resolves the failure.
@aiuto aiuto added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Sep 5, 2026
@aiuto
aiuto requested review from a team as code owners September 5, 2026 19:01
@aiuto aiuto added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Sep 5, 2026
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Sep 5, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Sep 5, 2026
@dd-octo-sts dd-octo-sts Bot added team/container-platform The Container Platform Team team/agent-build labels Sep 5, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

The patch is correct. The cache and image exports consistently force gzip compression, matching the existing Docker media types. No actionable regressions found. Validation was limited to static review; CI builds remain necessary to confirm the fix.

@dd-octo-sts

dd-octo-sts Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 44 0 0

ℹ️ Diff available in the job log.

@datadog-prod-us1-6

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 02d2f08e:

Results for datadog-agent_7.85.0~devel.git.27.49790c2.pipeline.135687391-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.85.0~devel.git.27.49790c2.pipeline.135687391-1_amd64.deb:

No change detected

@aiuto aiuto added the ask-review Ask in slack required teams to review this PR label Sep 5, 2026
@Ishirui
Ishirui merged commit f98a88d into main Sep 6, 2026
435 of 455 checks passed
@Ishirui
Ishirui deleted the aiuto/fix_jmx branch September 6, 2026 16:27
@github-actions github-actions Bot added this to the 7.85.0 milestone Sep 6, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 6, 2026

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: f2569c4d-edc2-4a85-8b0b-b51be8fd4aa7

Baseline: 02d2f08
Comparison: f98a88d
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization -6.27 [-6.49, -6.06] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization -11.14 [-11.32, -10.96] 1 Logs
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -14.80 [-15.02, -14.58] 1 Logs
quality_gate_logs % cpu utilization -38.91 [-39.68, -38.14] 1 Logs bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_private_action_runner memory utilization -0.49 [-0.62, -0.36] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization -2.87 [-2.91, -2.84] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -3.35 [-3.39, -3.32] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -3.38 [-3.45, -3.31] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -3.40 [-3.44, -3.36] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -3.51 [-3.55, -3.47] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -6.27 [-6.49, -6.06] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization -11.14 [-11.32, -10.96] 1 Logs
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -14.80 [-15.02, -14.58] 1 Logs
quality_gate_logs % cpu utilization -38.91 [-39.68, -38.14] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.63MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 744.43KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 517.86MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 215.30MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.45MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 369.22 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 21 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 440.83MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.84MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 29.25 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 325.51MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.24 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 304.76MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 25.06 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 313.08MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask in slack required teams to review this PR changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build team/container-platform The Container Platform Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants