Conversation
aiuto
added
changelog/no-changelog
github-actions
Bot
added
the
short review
Collaborator
Author
|
@chouquette IIRC, the complaint about ownership came up in your iot change. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AI review by Codex (OpenAI) - workflow run
The patch is correct. It changes the default owner of /cmd/ to @DataDog/agent-build while preserving subsequent, more specific ownership rules. No actionable issues found.
This comment has been minimized.
This comment has been minimized.
Contributor
Files inventory check summaryFile checks results against ancestor 02d2f08e: Results for datadog-agent_7.85.0~devel.git.28.e096238.pipeline.135684726-1_amd64.deb:No change detected Results for datadog-iot-agent_7.85.0~devel.git.28.e096238.pipeline.135684726-1_amd64.deb:No change detected |
Collaborator
Author
|
The broken test is broken at head on main. Don't worry about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes ownership of /cmd/ from fleet-remediation to agent-build.
Motivation
It clearly should not be owned by fleet-remediation, and they have complained about the spam.