Skip to content

Add per-agent log_level settings for config streaming - #55904

Draft
rahulkaukuntla wants to merge 1 commit into
mainfrom
configstream/per-agent-config-keys
Draft

Add per-agent log_level settings for config streaming#55904
rahulkaukuntla wants to merge 1 commit into
mainfrom
configstream/per-agent-config-keys

Conversation

@rahulkaukuntla

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds three namespaced settings to the core Agent schema — security_agent.log_level, process_config.log_level, apm_config.log_level — each with its DD_* env vars and an empty-string default, alongside their existing log_file siblings. Also makes the security_agent section public.

Motivation

Under config streaming the core Agent is the source of truth, so a setting that applies to only one remote agent needs a home on the core Agent. log_level is the case that cannot be hoisted: it is divergent by design, rendered per container. Empty string means "no override", which is what makes the remap in the next branch retractable.

Describe how you validated your changes

schema.lint and schema.codegen succeed and emit the expected BindEnvAndSetDefault calls; dda inv tidy, linter.go and dda inv test clean. Live: all three keys resolve on a running core Agent from their env vars.

Additional Notes

system_probe_config.log_level already exists and is unchanged.

The release note describes behaviour that only exists once the next branch lands, so A1 and A2 must ship together. Bottom of the config-streaming stack; base is main.

Add security_agent.log_level, process_config.log_level and
apm_config.log_level to the core schema, mirroring the existing
system_probe_config.log_level. They default to an empty string so a
consumer-side remap can tell 'no override' from an explicit value.
@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/fleet-automation team/agent-apm trace-agent labels Sep 4, 2026
@github-actions github-actions Bot added the medium review PR review might take time label Sep 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

Patch is incorrect: the new settings are registered but not consumed by the respective agents, so the documented override behavior does not exist in this change.

Comment on lines +727 to +728
visibility: public
description: |-

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This claims an override that this patch does not implement. Daemon logging still reads the global log_level in comp/core/log/def/params.go, and there is no remapping/consumer for any of the three new namespaced keys. Consequently these settings and their environment variables currently have no effect. Please include the consumption/remapping change in this PR (and tests), or defer the public settings and release note until that change lands.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 55.30% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d09f2dc | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: a69c411c-5aed-462f-8dcc-4013bb987562

Baseline: cbbd916
Comparison: d09f2dc
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization +0.45 [+0.20, +0.70] 1 Logs
quality_gate_idle_all_features memory utilization +0.42 [+0.38, +0.45] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.25 [+0.21, +0.30] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization +0.22 [+0.15, +0.30] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization +0.18 [-0.03, +0.40] 1 Logs
quality_gate_metrics_logs memory utilization +0.13 [-0.10, +0.36] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.09 [+0.05, +0.13] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.29 [-0.42, -0.16] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.72 [-0.76, -0.68] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.74 [-1.61, +0.14] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.39MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 745.98KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 517.13MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 19 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 212.22MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.45MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 371.82 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 20 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 424.65MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 71.97MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 30.99 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 326.33MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 63.93 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 299.74MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 23.03 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 314.91MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cbbd916
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 768.465 → 771.220
agent_deb_amd64_fips N/A N/A → 715.045 → 718.020
agent_heroku_amd64 N/A N/A → 316.125 → 322.460
agent_msi N/A N/A → 647.741 → 662.360
agent_rpm_amd64 N/A N/A → 768.448 → 771.190
agent_rpm_amd64_fips N/A N/A → 715.028 → 718.020
agent_rpm_arm64 N/A N/A → 740.389 → 744.370
agent_rpm_arm64_fips N/A N/A → 691.526 → 695.880
agent_suse_amd64 N/A N/A → 768.448 → 771.190
agent_suse_amd64_fips N/A N/A → 715.028 → 718.020
agent_suse_arm64 N/A N/A → 740.389 → 744.370
agent_suse_arm64_fips N/A N/A → 691.526 → 695.880
docker_agent_amd64 N/A N/A → 827.428 → 828.420
docker_agent_arm64 N/A N/A → 824.424 → 828.440
docker_agent_jmx_amd64 N/A N/A → 1018.340 → 1019.630
docker_agent_jmx_arm64 N/A N/A → 1004.116 → 1008.130
docker_cluster_agent_amd64 N/A N/A → 212.687 → 213.660
docker_cluster_agent_arm64 N/A N/A → 225.718 → 226.660
docker_cws_instrumentation_amd64 N/A N/A → 7.439 → 8.400
docker_cws_instrumentation_arm64 N/A N/A → 6.877 → 7.110
docker_dogstatsd_amd64 N/A N/A → 39.557 → 40.440
docker_dogstatsd_arm64 N/A N/A → 37.623 → 38.580
docker_host_profiler_amd64 N/A N/A → 307.574 → 319.480
docker_host_profiler_arm64 N/A N/A → 318.792 → 330.690
dogstatsd_deb_amd64 N/A N/A → 30.303 → 31.220
dogstatsd_deb_arm64 N/A N/A → 28.315 → 29.590
dogstatsd_rpm_amd64 N/A N/A → 30.303 → 31.220
dogstatsd_suse_amd64 N/A N/A → 30.303 → 31.220
iot_agent_deb_amd64 N/A N/A → 46.651 → 47.550
iot_agent_deb_arm64 N/A N/A → 43.280 → 44.220
iot_agent_deb_armhf N/A N/A → 44.094 → 45.020
iot_agent_rpm_amd64 N/A N/A → 46.652 → 47.550
iot_agent_suse_amd64 N/A N/A → 46.651 → 47.550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant