Skip to content

Remap per-agent log_level onto the base key in the consumer - #55903

Draft
rahulkaukuntla wants to merge 1 commit into
configstream/per-agent-config-keysfrom
configstream/consumer-override-remap
Draft

Remap per-agent log_level onto the base key in the consumer#55903
rahulkaukuntla wants to merge 1 commit into
configstream/per-agent-config-keysfrom
configstream/consumer-override-remap

Conversation

@rahulkaukuntla

Copy link
Copy Markdown
Contributor

What does this PR do?

Folds a streamed per-agent log_level onto the base log_level key in the consumer: security_agent.log_level for the security-agent, process_config.log_level for the process-agent, apm_config.log_level for the trace-agent. Written at SourceAgentRuntime and retracted when the namespaced value goes empty, so the override is not sticky.

Motivation

The keys added in the previous branch are inert on their own — the logger's update callback listens for the literal key log_level. This is what makes a per-agent level set on the core Agent actually take effect, and stay live-reconfigurable, on the remote.

Describe how you validated your changes

Unit and integration tests, linter.go clean. Live, with the global at info and each namespaced key at debug on the core Agent: every remote logged at debug, and only after its snapshot applied. With no namespaced key set, each fell back to the global. agent config set log_level debug on the running core Agent re-leveled a running trace-agent.

Additional Notes

The table is declared entry by entry, never a prefix strip — security_agent.cmd_port, apm_config.env and the internal_profiling family all share a trailing name with a global that means something else.

No system-probe entry: system_probe_config.* is declared only on the system-probe config object, so the core Agent never resolves or streams it. System-probe's own log_level keeps working unchanged through the existing deprecateString fold in pkg/system-probe/config/adjust.go. The consequence is that it is the one member of this family that cannot be made live-reconfigurable via the stream.

Declares a per-ClientName table folding the namespaced log_level settings
onto log_level after each applied snapshot or update, so the logger's
OnUpdate callback (which matches the literal key) fires. Writes use
SourceAgentRuntime and are retracted once the namespaced key stops
carrying a value.

Readiness moves out of applySnapshot into markReady, called after the
remap, so waitForReady cannot release before the base key holds the
override.
@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 85.71%
Overall Coverage: 55.30% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a70f9be | Docs | View more details | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 2403f3ad-fdfd-4c1e-bc95-410e18c4dae0

Baseline: cbbd916
Comparison: a70f9be
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.14 [+0.10, +0.19] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.12 [+0.09, +0.16] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization +0.04 [-0.17, +0.25] 1 Logs
quality_gate_idle_all_features memory utilization -0.10 [-0.14, -0.07] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.13 [-0.21, -0.05] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization -0.31 [-0.43, -0.18] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.37 [-0.42, -0.32] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.40 [-0.63, -0.16] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.90 [-1.14, -0.66] 1 Logs
quality_gate_logs % cpu utilization -1.94 [-2.79, -1.08] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.50MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 747.78KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 520.83MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.14MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 217.30MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.43MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 398.13 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 21 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 426.82MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.34MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 36.74 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 327.33MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 64.82 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 308.39MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 26.16 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 315.34MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cbbd916
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 768.472 → 771.220
agent_deb_amd64_fips N/A N/A → 715.064 → 718.020
agent_heroku_amd64 N/A N/A → 316.129 → 322.460
agent_msi N/A N/A → 647.752 → 662.360
agent_rpm_amd64 N/A N/A → 768.456 → 771.190
agent_rpm_amd64_fips N/A N/A → 715.048 → 718.020
agent_rpm_arm64 N/A N/A → 740.405 → 744.370
agent_rpm_arm64_fips N/A N/A → 691.534 → 695.880
agent_suse_amd64 N/A N/A → 768.456 → 771.190
agent_suse_amd64_fips N/A N/A → 715.048 → 718.020
agent_suse_arm64 N/A N/A → 740.405 → 744.370
agent_suse_arm64_fips N/A N/A → 691.534 → 695.880
docker_agent_amd64 N/A N/A → 827.436 → 828.420
docker_agent_arm64 N/A N/A → 824.440 → 828.440
docker_agent_jmx_amd64 N/A N/A → 1018.348 → 1019.630
docker_agent_jmx_arm64 N/A N/A → 1004.132 → 1008.130
docker_cluster_agent_amd64 N/A N/A → 212.687 → 213.660
docker_cluster_agent_arm64 N/A N/A → 225.718 → 226.660
docker_cws_instrumentation_amd64 N/A N/A → 7.439 → 8.400
docker_cws_instrumentation_arm64 N/A N/A → 6.877 → 7.110
docker_dogstatsd_amd64 N/A N/A → 39.557 → 40.440
docker_dogstatsd_arm64 N/A N/A → 37.623 → 38.580
docker_host_profiler_amd64 N/A N/A → 307.574 → 319.480
docker_host_profiler_arm64 N/A N/A → 318.792 → 330.690
dogstatsd_deb_amd64 N/A N/A → 30.303 → 31.220
dogstatsd_deb_arm64 N/A N/A → 28.315 → 29.590
dogstatsd_rpm_amd64 N/A N/A → 30.303 → 31.220
dogstatsd_suse_amd64 N/A N/A → 30.303 → 31.220
iot_agent_deb_amd64 N/A N/A → 46.651 → 47.550
iot_agent_deb_arm64 N/A N/A → 43.280 → 44.220
iot_agent_deb_armhf N/A N/A → 44.094 → 45.020
iot_agent_rpm_amd64 N/A N/A → 46.652 → 47.550
iot_agent_suse_amd64 N/A N/A → 46.651 → 47.550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant