fix(e2e): return correct success message from destroy_remote_stack_api

[chouetz]

Summary

• Fixes a regression from Revert "fix(e2e): pause e2e_init cancellation pending stackcleaner fix (#55831)" #55894 (revert of fix(e2e): pause e2e_init cancellation pending stackcleaner fix #55831): destroy_remote_stack_api was returning "Failed to destroy stack ... using the API" on the success path, which cleanup_remote_stacks prints right before also announcing the same stack was destroyed successfully, producing contradictory CI logs.
• Restores the correct success message, as flagged in review.

Test plan

• dda inv linter.python passes

[github-actions]

AI review by Codex (OpenAI) - workflow run

Patch is correct. The success path now reports that cleanup was submitted, while failures retain their exception text; this matches the caller’s handling and removes the contradictory failure message.

[datadog-datadog-prod-us1]

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 60.62% (+5.35%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: aab0f54 | Docs | View more details | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor cc466279:

Results for datadog-agent_7.85.0~devel.git.16.aab0f54.pipeline.135534522-1_amd64.deb:

No change detected

Results for datadog-iot-agent_7.85.0~devel.git.16.aab0f54.pipeline.135534522-1_amd64.deb:

No change detected

[quentinus95]

When looking at callers, I don't understand why we have a distinct stdout and stderr
I would rather have a single message variable

But this is non blocking

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor cc46627
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	N/A	N/A → 768.464 → 771.220
✅	agent_deb_amd64_fips	N/A	N/A → 715.044 → 718.020
✅	agent_heroku_amd64	N/A	N/A → 316.124 → 322.460
✅	agent_rpm_amd64	N/A	N/A → 768.447 → 771.190
✅	agent_rpm_amd64_fips	N/A	N/A → 715.027 → 718.020
✅	agent_rpm_arm64	N/A	N/A → 740.384 → 744.370
✅	agent_rpm_arm64_fips	N/A	N/A → 691.517 → 695.880
✅	agent_suse_amd64	N/A	N/A → 768.447 → 771.190
✅	agent_suse_amd64_fips	N/A	N/A → 715.027 → 718.020
✅	agent_suse_arm64	N/A	N/A → 740.384 → 744.370
✅	agent_suse_arm64_fips	N/A	N/A → 691.517 → 695.880
✅	docker_agent_amd64	N/A	N/A → 827.427 → 828.420
✅	docker_agent_arm64	N/A	N/A → 824.419 → 828.440
✅	docker_agent_jmx_amd64	N/A	N/A → 1018.339 → 1019.630
✅	docker_agent_jmx_arm64	N/A	N/A → 1004.111 → 1008.130
✅	docker_cluster_agent_amd64	N/A	N/A → 212.686 → 213.660
✅	docker_cluster_agent_arm64	N/A	N/A → 225.718 → 226.660
✅	docker_cws_instrumentation_amd64	N/A	N/A → 7.439 → 8.400
✅	docker_cws_instrumentation_arm64	N/A	N/A → 6.877 → 7.110
✅	docker_dogstatsd_amd64	N/A	N/A → 39.557 → 40.440
✅	docker_dogstatsd_arm64	N/A	N/A → 37.623 → 38.580
✅	docker_host_profiler_amd64	N/A	N/A → 307.574 → 319.480
✅	docker_host_profiler_arm64	N/A	N/A → 318.792 → 330.690
✅	dogstatsd_deb_amd64	N/A	N/A → 30.303 → 31.220
✅	dogstatsd_deb_arm64	N/A	N/A → 28.315 → 29.590
✅	dogstatsd_rpm_amd64	N/A	N/A → 30.303 → 31.220
✅	dogstatsd_suse_amd64	N/A	N/A → 30.303 → 31.220
✅	iot_agent_deb_amd64	N/A	N/A → 46.651 → 47.550
✅	iot_agent_deb_arm64	N/A	N/A → 43.280 → 44.220
✅	iot_agent_deb_armhf	N/A	N/A → 44.094 → 45.020
✅	iot_agent_rpm_amd64	N/A	N/A → 46.651 → 47.550
✅	iot_agent_suse_amd64	N/A	N/A → 46.650 → 47.550

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 2c67c27b-da15-4e07-af6b-db568cc0c33a

Baseline: cbbd916
Comparison: aab0f54
Diff

Optimization Goals: ❌ Regression(s) detected

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	quality_gate_logs	% cpu utilization	+5.28	[+4.38, +6.18]	1	Logs bounds checks dashboard

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
❌	quality_gate_logs	% cpu utilization	+5.28	[+4.38, +6.18]	1	Logs bounds checks dashboard
➖	dsd_uds_10mb_3k_timestamped_contexts_cpu	% cpu utilization	+0.19	[-0.06, +0.43]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.09	[+0.05, +0.12]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	+0.08	[-0.04, +0.20]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	+0.03	[-0.01, +0.07]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	-0.11	[-0.19, -0.03]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.16	[-0.20, -0.12]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	-0.22	[-0.26, -0.18]	1	Logs bounds checks dashboard
➖	dsd_uds_10mb_3k_timestamped_contexts_memory	memory utilization	-0.46	[-0.66, -0.25]	1	Logs
➖	quality_gate_metrics_logs	memory utilization	-1.52	[-1.75, -1.29]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	4 ≤ 5	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	173.69MiB ≤ 179MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	750.80KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	4 ≤ 5	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	527.92MiB ≤ 537MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.14MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	19 ≤ 40	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	214.76MiB ≤ 228MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.47MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	369.36 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	17 ≤ 40	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	420.49MiB ≤ 455MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.94GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	72.15MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	30.15 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	327.80MiB ≤ 355MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	61.89 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	306.63MiB ≤ 335MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	23.00 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	314.44MiB ≤ 345MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.