feat(orchestrator): collect Gateway and Inference API resources by default - #55888
Draft
aureleoules wants to merge 2 commits into
Draft
feat(orchestrator): collect Gateway and Inference API resources by default#55888aureleoules wants to merge 2 commits into
aureleoules wants to merge 2 commits into
Conversation
aureleoules
added
qa/done
github-actions
Bot
added
long review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AI review by Codex (OpenAI) - workflow run
patch is correct — the changed skill is well-scoped, clearly triggered, owned, concise, and defines a verifiable release-note workflow.
| --- | ||
| name: create-release-note | ||
| description: Create a reno release note for a PR or change | ||
| description: Create a reno release note for a PR or change. Use when asked to create, add, or write a release note or changelog entry. |
Contributor
There was a problem hiding this comment.
Skill assessment — Priority 3
- Description (triggering): 23/25
- Writing philosophy: 21/25
- Structure and progressive disclosure: 25/25
- Output definition and examples: 23/25
- Total: 92/100
- Recommendation: Approve
Top actionable improvements:
- Narrow the description further by mentioning Datadog Agent/reno release notes, reducing accidental triggers for unrelated changelog systems.
- Add a short rationale for the section-selection and APM-prefix rules so future maintainers understand the underlying constraints.
- Add one complete input-to-generated-YAML example; the current command, template, and examples are useful but distributed across sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Collects standard Gateway API and Gateway API Inference Extension custom resources in Orchestrator Explorer by default, with fallbacks for versions served by older releases. It preserves the existing
gateway_apiopt-out and avoids duplicate collection when the same resource is configured explicitly at another version.It also makes version discovery resource-aware and adds an orchestrator E2E covering HTTPRoute and InferencePool manifests.
Motivation
Make Gateway and inference-routing topology available without manual collector configuration.
Backend allowlisting and default RBAC are supplied by the companion dd-go, Operator, Helm, and internal Operator chart PRs. Those dependencies must roll out before the Agent release.
Companion PRs:
Describe how you validated your changes
dda inv test --targets=./pkg/collector/corechecks/cluster/orchestrator/...dda inv linter.go --targets=./pkg/collector/corechecks/cluster/orchestrator,./pkg/collector/corechecks/cluster/orchestrator/discoverydda inv linter.go --module=test/new-e2e --targets=./tests/orchestratorbazel run //bazel/buildifierbazel build //test/new-e2e/tests/orchestrator:orchestrator_testThe cloud E2E was not provisioned locally; the existing orchestrator CI job will run it.
Additional Notes
Set
orchestrator_explorer.custom_resources.ootb.gateway_apitofalseto opt out.