Skip to content

[ACTP] add support to manage par-control from dd-procmgr in container… - #55882

Draft
dd-gplassard wants to merge 1 commit into
mainfrom
gabriel.plassard/containerize-support-for-par-control
Draft

[ACTP] add support to manage par-control from dd-procmgr in container…#55882
dd-gplassard wants to merge 1 commit into
mainfrom
gabriel.plassard/containerize-support-for-par-control

Conversation

@dd-gplassard

Copy link
Copy Markdown
Contributor

…ized env

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Sep 4, 2026
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label Sep 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review by Codex (OpenAI) - workflow run

Patch is correct. The environment inheritance is opt-in, existing process definitions retain sanitized environments, and the container packaging and process-manager behavior are covered by appropriate tests.

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 55.30% (+0.03%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bb6a6a0 | Docs | View more details | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor 17e278e3:

Results for datadog-agent_7.85.0~devel.git.4.bb6a6a0.pipeline.135461619-1_amd64.deb:

Detected file changes:

2 Added files:

  • opt/datadog-agent/privateactionrunner/processes.d/datadog-agent-par-control.yaml (794.0 B)
  • opt/datadog-agent/privateactionrunner/processes.d/datadog-agent-action-executor.yaml (561.0 B)

Results for datadog-iot-agent_7.85.0~devel.git.4.bb6a6a0.pipeline.135461619-1_amd64.deb:

No change detected

@dd-octo-sts

dd-octo-sts Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 17e278e
📊 Static Quality Gates Dashboard
🔗 SQG Job

33 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 767.652 MiB
agent_deb_amd64_fips 714.234 MiB
agent_heroku_amd64 316.116 MiB
agent_msi 647.733 MiB
agent_rpm_amd64 767.635 MiB
agent_rpm_amd64_fips 714.218 MiB
agent_rpm_arm64 739.606 MiB
agent_rpm_arm64_fips 690.738 MiB
agent_suse_amd64 767.635 MiB
agent_suse_amd64_fips 714.218 MiB
agent_suse_arm64 739.606 MiB
agent_suse_arm64_fips 690.738 MiB
docker_agent_amd64 826.615 MiB
docker_agent_arm64 823.642 MiB
docker_agent_jmx_amd64 1017.527 MiB
docker_agent_jmx_arm64 1003.334 MiB
docker_cluster_agent_amd64 212.679 MiB
docker_cluster_agent_arm64 225.718 MiB
docker_cws_instrumentation_amd64 7.439 MiB
docker_cws_instrumentation_arm64 6.877 MiB
docker_dogstatsd_amd64 39.557 MiB
docker_dogstatsd_arm64 37.623 MiB
docker_host_profiler_amd64 307.576 MiB
docker_host_profiler_arm64 318.792 MiB
dogstatsd_deb_amd64 30.299 MiB
dogstatsd_deb_arm64 28.307 MiB
dogstatsd_rpm_amd64 30.299 MiB
dogstatsd_suse_amd64 30.299 MiB
iot_agent_deb_amd64 46.647 MiB
iot_agent_deb_arm64 43.276 MiB
iot_agent_deb_armhf 44.090 MiB
iot_agent_rpm_amd64 46.647 MiB
iot_agent_suse_amd64 46.646 MiB

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Job ID: 1b959ce8-e05c-4646-b952-e43a02037aac

Baseline: 17e278e
Comparison: bb6a6a0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.49 [-0.37, +1.34] 1 Logs bounds checks dashboard
quality_gate_private_action_runner memory utilization +0.29 [+0.16, +0.42] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.16 [+0.11, +0.21] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization -0.01 [-0.04, +0.03] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.09 [-0.13, -0.05] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.16 [-0.23, -0.08] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.23 [-0.46, +0.00] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization -0.31 [-0.36, -0.27] 1 Logs bounds checks dashboard
dsd_uds_10mb_3k_timestamped_contexts_cpu % cpu utilization -0.44 [-0.68, -0.21] 1 Logs
dsd_uds_10mb_3k_timestamped_contexts_memory memory utilization -0.60 [-0.82, -0.39] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gate_idle intake_connections 10/10 4 ≤ 5 bounds checks dashboard
quality_gate_idle memory_usage 10/10 174.78MiB ≤ 179MiB bounds checks dashboard
quality_gate_idle total_bytes_received 10/10 748.32KiB ≤ 819.20KiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 2 ≤ 5 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 467.78MiB ≤ 537MiB bounds checks dashboard
quality_gate_idle_all_features total_bytes_received 10/10 1.13MiB ≤ 1.25MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 18 ≤ 40 bounds checks dashboard
quality_gate_logs memory_usage 10/10 214.22MiB ≤ 228MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_logs total_bytes_received 10/10 263.05MiB ≤ 292MiB bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 352.22 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 20 ≤ 40 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 412.80MiB ≤ 455MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs total_bytes_received 10/10 0.94GiB ≤ 1.04GiB bounds checks dashboard
quality_gate_private_action_runner memory_usage 10/10 72.08MiB ≤ 75MiB bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 36.61 ≤ 100 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 328.83MiB ≤ 355MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 61.49 ≤ 200 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 303.06MiB ≤ 335MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 23.86 ≤ 100 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 313.20MiB ≤ 345MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR long review PR is complex, plan time to review it team/agent-build team/agent-runtimes team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant