[ABLD-310] Add --enable_bazel flag to privateactionrunner.build - #55554
[ABLD-310] Add --enable_bazel flag to privateactionrunner.build#55554aiuto wants to merge 5 commits into
Conversation
## Motivation Omnibus is being deprecated in favor of Bazel as the primary build system. This adds an opt-in `--enable_bazel` flag to `privateactionrunner.build`, mirroring the pattern already used by `loader.build`, so developers can build the privateactionrunner binary via `bazel build //cmd/privateactionrunner:privateactionrunner` instead of `go build`. ## What this change does - Adds `enable_bazel=False` to `privateactionrunner.build`. When True, it calls the new `build_go_binary_with_bazel()` helper (copied from tasks/libs/build/bazel.py on the loader.build branch) which runs `bazel build <target>` and copies the resulting binary into place. - Adds `build_go_binary_with_bazel()` to tasks/libs/build/bazel.py. ### Known limitations - Windows is explicitly unsupported for now: on Windows, the legacy go_build() path runs build_messagetable()/build_rc() to produce cmd/privateactionrunner/rsrc.syso, which gets embedded into the binary. The Bazel target //cmd/privateactionrunner:privateactionrunner does not yet wire in //cmd/privateactionrunner/windows_resources:rsrc, so a bazel-built Windows binary would be missing those resources. Passing `--enable-bazel` on Windows raises a clear NotImplementedError rather than silently producing an incomplete binary. Since this flag is a developer opt-in (default False) and this repo also ships Linux/macOS, this is an acceptable tactical scoping rather than blocking the change. ## How did you validate this - `dda inv -- -e privateactionrunner.build --enable-bazel` succeeds on macOS (darwin/arm64) and produces a valid Mach-O binary that runs (`./bin/privateactionrunner/privateactionrunner version`). - `dda inv -- -e privateactionrunner.build` (no flag) still succeeds via the unchanged go_build() path. - `dda inv linter.python` passes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
AI review by Codex (OpenAI) - workflow run
Patch is incorrect because the Bazel-built binary does not receive the standard Agent version/link settings.
| "target does not embed Windows resources (rsrc.syso) that the legacy go_build() " | ||
| "path produces. See //cmd/privateactionrunner/windows_resources:rsrc. (ABLD-310)" | ||
| ) | ||
| build_go_binary_with_bazel("//cmd/privateactionrunner:privateactionrunner", BIN_PATH) |
There was a problem hiding this comment.
The selected target is a raw go_binary, unlike migrated binaries such as cmd/loader, which use dd_agent_go_binary. Consequently this path leaves pkg/version.AgentVersion at 0.0.0-dev instead of applying the version flags used by the legacy build, affecting the version command and version sent to remote config. Convert the target to dd_agent_go_binary before exposing it here.
…itioning targets ## What this change does Resolves the built binary's output path via `bazel cquery --output=files` instead of `bazel info bazel-bin` + a hand-built `<package>/<name>_/<name>` path. Some go_binary targets (e.g. ones with custom gotags) build under a Starlark configuration transition, which places their outputs in a `<platform>-ST-<hash>` bazel-out subdirectory that the plain bazel-bin symlink does not point to, so the original approach threw FileNotFoundError for those targets. ## Motivation Omnibus deprecation ## How did you validate this Ran `dda inv -- -e privateactionrunner.build --enable-bazel` (non-Windows path) and confirmed it still produces a valid binary via bazel. privateactionrunner itself doesn't trigger a transition so this is a preventive fix carried over from the otel-agent PR, which did hit the bug.
Files inventory check summaryFile checks results against ancestor 6ec84e5e: Results for datadog-agent_7.84.0~devel.git.558.851dce3.pipeline.133833397-1_amd64.deb:No change detected Results for datadog-iot-agent_7.84.0~devel.git.558.851dce3.pipeline.133833397-1_amd64.deb:No change detected |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6ec84e5 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +2.26 | [+1.38, +3.13] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_private_action_runner | memory utilization | +0.43 | [+0.31, +0.56] | 1 | Logs bounds checks dashboard |
| ➖ | dsd_uds_10mb_3k_timestamped_contexts_memory | memory utilization | +0.30 | [+0.09, +0.51] | 1 | Logs |
| ➖ | dsd_uds_10mb_3k_timestamped_contexts_cpu | % cpu utilization | +0.14 | [-0.11, +0.38] | 1 | Logs |
| ➖ | quality_gate_security_no_fs_load | memory utilization | +0.09 | [+0.01, +0.17] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.05 | [+0.01, +0.09] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_idle | memory utilization | +0.01 | [-0.04, +0.06] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_security_mean_fs_load | memory utilization | -0.05 | [-0.09, -0.02] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_idle | memory utilization | -0.08 | [-0.13, -0.04] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | -0.14 | [-0.37, +0.09] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | quality_gate_idle | intake_connections | 10/10 | 4 = 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 174.04MiB ≤ 179MiB | bounds checks dashboard |
| ✅ | quality_gate_idle | total_bytes_received | 10/10 | 749.58KiB ≤ 819.20KiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 4 = 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 523.12MiB ≤ 537MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | total_bytes_received | 10/10 | 1.14MiB ≤ 1.25MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 16 ≤ 40 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 216.22MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_logs | total_bytes_received | 10/10 | 263.14MiB ≤ 292MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 362.12 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 19 ≤ 40 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 433.06MiB ≤ 455MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | total_bytes_received | 10/10 | 0.94GiB ≤ 1.04GiB | bounds checks dashboard |
| ✅ | quality_gate_private_action_runner | memory_usage | 10/10 | 72.58MiB ≤ 75MiB | bounds checks dashboard |
| ✅ | quality_gate_security_idle | cpu_usage | 10/10 | 28.38 ≤ 100 | bounds checks dashboard |
| ✅ | quality_gate_security_idle | memory_usage | 10/10 | 326.08MiB ≤ 355MiB | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | cpu_usage | 10/10 | 60.59 ≤ 200 | bounds checks dashboard |
| ✅ | quality_gate_security_mean_fs_load | memory_usage | 10/10 | 306.15MiB ≤ 335MiB | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | cpu_usage | 10/10 | 19.64 ≤ 100 | bounds checks dashboard |
| ✅ | quality_gate_security_no_fs_load | memory_usage | 10/10 | 316.27MiB ≤ 345MiB | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
- quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
25 successful checks with minimal change (< 2 KiB)
|
Error message now states only the current limitation, with no ticket references or "yet" language. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adopts the shared helper's canonical name/shape from the dogstatsd PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…vor flag Propagates the shared helper change from the dogstatsd PR (args param passed through to both build and cquery). For tasks with a fips_mode flag, pass --//packages/agent:flavor=fips instead of rejecting fips_mode outright. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Motivation
Omnibus is being deprecated in favor of Bazel as the primary build system. This adds an opt-in
--enable_bazelflag toprivateactionrunner.build, mirroring the pattern already used byloader.build, so developers can build the privateactionrunner binary viabazel build //cmd/privateactionrunner:privateactionrunnerinstead ofgo build.What this change does
enable_bazel=Falsetoprivateactionrunner.build. WhenTrue, it calls the newbuild_go_binary_with_bazel()helper, which runsbazel build <target>and copies the resulting binary into place.build_go_binary_with_bazel()totasks/libs/build/bazel.py(same helper introduced on theloader.build--enable_bazel branch).Known limitations
go_build()path runsbuild_messagetable()/build_rc()to producecmd/privateactionrunner/rsrc.syso, which gets embedded into the binary. The Bazel target//cmd/privateactionrunner:privateactionrunnerdoes not yet wire in//cmd/privateactionrunner/windows_resources:rsrc, so a bazel-built Windows binary would be missing those resources. Passing--enable-bazelon Windows raises a clearNotImplementedErrorrather than silently producing an incomplete binary. Since this flag is a developer opt-in (defaultFalse), and this repo also ships Linux/macOS, this is an acceptable tactical scoping rather than blocking the change. Follow-up: wire thewindows_resources:rsrctarget into the Bazelgo_binarytarget so Windows can be supported too.How did you validate this
dda inv -- -e privateactionrunner.build --enable-bazelsucceeds on macOS (darwin/arm64) and produces a valid Mach-O binary that runs (./bin/privateactionrunner/privateactionrunner version).dda inv -- -e privateactionrunner.build(no flag) still succeeds via the unchangedgo_build()path.dda inv linter.pythonpasses.🤖 Generated with Claude Code