feat(heap-profiling): add heap profiling support rev2 [PROF-15190]

[scottgerring]

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

[dd-octo-sts]

Go Package Import Differences

Baseline: 2c2da66
Comparison: 8b58ad3

binary	os	arch	change
host-profiler	linux	amd64	+3, -0 +github.com/parca-dev/usdt +go.opentelemetry.io/ebpf-profiler/liveheap +go.opentelemetry.io/ebpf-profiler/usdt
host-profiler	linux	arm64	+3, -0 +github.com/parca-dev/usdt +go.opentelemetry.io/ebpf-profiler/liveheap +go.opentelemetry.io/ebpf-profiler/usdt

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor 2c2da66c:

Results for datadog-agent_7.83.0~devel.git.296.8b58ad3.pipeline.126162027-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 2c2da66
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_msi	+2.14 KiB (0.00% increase, -0.01% of buffer)	639.272 → 639.274 → 656.640
✅	agent_rpm_arm64_fips	+8.13 KiB (0.00% increase, -0.21% of buffer)	685.040 → 685.048 → 688.910
✅	agent_suse_arm64_fips	+8.13 KiB (0.00% increase, -0.21% of buffer)	685.040 → 685.048 → 688.910
✅	docker_host_profiler_amd64	+279.04 KiB (0.09% increase, -1.87% of buffer)	303.090 → 303.363 → 317.640
✅	docker_host_profiler_arm64	+284.13 KiB (0.09% increase, -1.94% of buffer)	314.604 → 314.882 → 328.900

28 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	750.443 MiB
✅	agent_deb_amd64_fips	705.243 MiB
✅	agent_heroku_amd64	307.481 MiB
✅	agent_rpm_amd64	750.427 MiB
✅	agent_rpm_amd64_fips	705.227 MiB
✅	agent_rpm_arm64	727.125 MiB
✅	agent_suse_amd64	750.427 MiB
✅	agent_suse_amd64_fips	705.227 MiB
✅	agent_suse_arm64	727.125 MiB
✅	docker_agent_amd64	809.124 MiB
✅	docker_agent_arm64	810.853 MiB
✅	docker_agent_jmx_amd64	1000.021 MiB
✅	docker_agent_jmx_arm64	990.403 MiB
✅	docker_cluster_agent_amd64	209.819 MiB
✅	docker_cluster_agent_arm64	222.890 MiB
✅	docker_cws_instrumentation_amd64	7.439 MiB
✅	docker_cws_instrumentation_arm64	6.877 MiB
✅	docker_dogstatsd_amd64	39.224 MiB
✅	docker_dogstatsd_arm64	37.368 MiB
✅	dogstatsd_deb_amd64	29.968 MiB
✅	dogstatsd_deb_arm64	28.008 MiB
✅	dogstatsd_rpm_amd64	29.968 MiB
✅	dogstatsd_suse_amd64	29.968 MiB
✅	iot_agent_deb_amd64	46.122 MiB
✅	iot_agent_deb_arm64	42.813 MiB
✅	iot_agent_deb_armhf	43.578 MiB
✅	iot_agent_rpm_amd64	46.122 MiB
✅	iot_agent_suse_amd64	46.121 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 35d2f882-c148-4e16-ac35-1b76126127dd

Baseline: 2c2da66
Comparison: 8b58ad3
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.29	[-0.70, +1.28]	1	Logs bounds checks dashboard
➖	quality_gate_security_no_fs_load	memory utilization	+0.25	[+0.16, +0.34]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.20	[-0.05, +0.44]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.12	[+0.08, +0.16]	1	Logs bounds checks dashboard
➖	quality_gate_private_action_runner	memory utilization	+0.07	[-0.06, +0.19]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.03	[-0.02, +0.09]	1	Logs bounds checks dashboard
➖	quality_gate_security_idle	memory utilization	-0.03	[-0.09, +0.02]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.12	[-0.16, -0.08]	1	Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	150.27MiB ≤ 154MiB	bounds checks dashboard
✅	quality_gate_idle	total_bytes_received	10/10	731.89KiB ≤ 819.20KiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
❌	quality_gate_idle_all_features	memory_usage	5/10	498.09MiB > 495MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	total_bytes_received	10/10	1.13MiB ≤ 1.25MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	187.38MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_logs	total_bytes_received	10/10	263.76MiB ≤ 292MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	353.47 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	396.98MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	total_bytes_received	10/10	0.93GiB ≤ 1.04GiB	bounds checks dashboard
✅	quality_gate_private_action_runner	memory_usage	10/10	71.95MiB ≤ 75MiB	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	28.33 ≤ 100	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	297.49MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	65.01 ≤ 200	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	275.77MiB ≤ 310MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	22.68 ≤ 100	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	289.38MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment	Variant	Replicates	Failure	Logs	Debug Dashboard
experiment_with_failures	baseline	0 (x8) 1 (x6)	Oom killed		Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Profiling Replicate Execution Failures (ddprof)

Note: Profiling replicas may still be executing. See the debug dashboard for up to date status.

Experiment	Variant	Replicates	Failure	Debug Dashboard
quality_gate_idle	comparison	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	baseline	10	Oom killed	Debug Dashboard
quality_gate_idle_all_features	comparison	10	Oom killed	Debug Dashboard
quality_gate_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	baseline	10	Oom killed	Debug Dashboard
quality_gate_metrics_logs	comparison	10	Oom killed	Debug Dashboard
quality_gate_security_idle	comparison	10	Crashed (exit code: 134)	Debug Dashboard
quality_gate_security_no_fs_load	baseline	10	Oom killed	Debug Dashboard
quality_gate_security_no_fs_load	comparison	10	Crashed (exit code: 134)	Debug Dashboard

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

• quality_gate_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_private_action_runner, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 5/10 replicas passed. Failed 5 which is > 0. Gate FAILED.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check total_bytes_received: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

[datadog-datadog-prod-us1-2]

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

[dd-octo-sts]

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

[dd-octo-sts]

This pull request was automatically closed because it has been stale for 15 days with no activity.

If this pull request is still relevant, please reopen it or create a new pull request with updated information.

Thanks!