Pull information about a StoryFormat from the format file itself#51
Open
sgranade wants to merge 1 commit intoDan-Q:masterfrom
Open
Pull information about a StoryFormat from the format file itself#51sgranade wants to merge 1 commit intoDan-Q:masterfrom
sgranade wants to merge 1 commit intoDan-Q:masterfrom
Conversation
…e itself, and the story file to record a story format's version in the 'format-version' tag on compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes pull a StoryFormat's name and version directly from the StoryFormat .js file, and add the format's version to the compiled output as a
format-versionattribute on thetw-storydatatag. That matches the recent behavior of Twine, and means that we can go back to compiled stories and confirm what version of the story format was used. It also divorces story formats' names from the directory name in thestoryFormatsdirectory, which then supports having multiple versions of the same story format.