test(client): add User-Agent header tests (DAK-7617) - #149
Merged
Conversation
PR#147 added the default dakera-go/<Version> User-Agent but shipped with no test. Adds TestUserAgentHeader (verifies header value on every request) and TestUserAgentHeader_Version (sanity-checks that Version is non-empty and contains a dot). Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dakera-go/<Version>as the defaultUser-Agentheader on every request (DAK-7617), but shipped with no test coverage.TestUserAgentHeader: spins up a test server, captures the header, assertsdakera-go/0.11.102value — same pattern as the existingTestAuthorizationHeader.TestUserAgentHeader_Version: sanity-checks thatVersionconstant is non-empty and contains a.(semver-like format the server analytics expect).Test plan
TestAuthorizationHeader(same imports, same httptest pattern)go test ./...🤖 Generated with Claude Code