Skip to content

feat: multiple contract enhancements (#169, #155, #156, #152) - #220

Merged
soomtochukwu merged 6 commits into
DXmakers:mainfrom
ayomideadeniran:issue-152-make-withdraw-transfer-usdc
May 30, 2026
Merged

feat: multiple contract enhancements (#169, #155, #156, #152)#220
soomtochukwu merged 6 commits into
DXmakers:mainfrom
ayomideadeniran:issue-152-make-withdraw-transfer-usdc

Conversation

@ayomideadeniran

Copy link
Copy Markdown

Description

This PR implements remediation items from the additional audit report across the Soroban contracts. It consolidates multiple fixes to improve the contract's robustness, correctness, and security.

Changes Included:

  • Validate allocation percentages exactly or define remainder behavior: Ensures that token allocation percentages are correctly validated to prevent calculation issues or remainder dust.
  • Add slippage parameters for Soroswap swaps: Implements slippage protection for all Soroswap swaps to prevent sandwich attacks and excessive value loss during transactions.
  • Add minimum amounts for add_liquidity: Enforces minimum deposit limits when adding liquidity, ensuring that small transactions don't inflate state or cause rounding errors.
  • Make withdraw transfer USDC to the user: Correctly redirects the withdrawn USDC directly to the user's wallet address instead of holding it.

Related Issues

Closes #169
Closes #155
Closes #156
Closes #152

Requirements Met

  • Updated contracts/src/lib.rs and tests as needed.
  • Preserved no_std compatibility.
  • Utilized typed errors and checked arithmetic.
  • All tests pass, format passes, and clippy has no new warnings.

@drips-wave

drips-wave Bot commented May 29, 2026

Copy link
Copy Markdown

@ayomideadeniran Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@soomtochukwu
soomtochukwu merged commit 52331c8 into DXmakers:main May 30, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants