[Contract 04] Implement real Blend withdraw invocation - #218
Merged
Conversation
…aw-invocation Implement real Blend withdraw invocation
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #151
Description
Added a generated typed client for the Blend pool by annotating the trait with #[soroban_sdk::contractclient(name = "BlendPoolClient")] and routed supply/withdraw/index-rate reads through BlendPoolClient calls (call_blend_supply, call_blend_withdraw, call_blend_index_rate).
Updated withdraw_from_blend to invoke the Blend pool withdraw, then apply checked updates to UserBlendPosition and TotalBTokens, and finally transfer the received USDC to the user.
Adjusted tests to register and use a stateful mock token (StatefulMockToken) and the MockBlendPoolClient to set index rates, and added assertions that the mock pool's BTokenSupply/TotalSupply reflect supplies and withdraws.
Formatting and lint adjustments (small formatting changes, #![allow(clippy::too_many_arguments)] to silence a known router signature warning) while preserving #![no_std] and checked arithmetic usage.
Testing
Ran cargo test in contracts and all unit tests passed (13 passed; 0 failed).
Ran cargo fmt --all -- --check and formatting check passed.
Ran cargo clippy and addressed warnings where practical; no new lints block this change.