Dlindeba/mib v3 naming #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
With these PRs, we are effectively dropping support for MIB v2, and accepting the risk that we may have to spend a non-significant amount of effort adding it back in if we ever need to use v2 hardware. With that mind, I think MIB v2 address maps and classes should just be renamed MIB v3. |
Collaborator
Author
|
Removed MIBV2 node, and removed extra classes from address table. Tested by running |
Collaborator
|
LGTM after small fixes, merging |
strilov
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added MIBV3IONode and address map for MIBV3 to interface with renamed firmware.
Testing checklist
Tested the MIB could synctime from the GIB and had an endpoint.