Propagate override logs correctly #747
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #731
Implements a fix that allows the propagation of overriding of log files correctly for all processes within the unified shell.
In drunc logging, there are options that allow the log files to append their timestamp in their filenames or not, effectively allowing them to be either overwritten or not.
Running
will alter the behaviour of the SSH_SHELL_process_manager log file, and also save the override_log choice in
UnifiedShellContext.Inside the drunc-unified-shell, running
will now check for several things. If any of the flags is passed, it the boot command will parse that choice into the boot process correctly. If no flag is passed, boot will then obtain from the
UnifiedShellContextthe choice when initialising the unified shell and use that insteadType of change
Key checklist
python -m pytest)pre-commit run --all-files)Testing checklist
Check out latest nightly (tested on
NFD_DEV_260109_A9) and this branch. Run various combinations ofWhat you should see is:
SSH_SHELL_process_manager, andbootaffects everything elseFurther checks
(Indicate issue here: # (issue))