Skip to content

Conversation

@emmuhamm
Copy link
Contributor

@emmuhamm emmuhamm commented Jan 15, 2026

Description

Fixes #731

Implements a fix that allows the propagation of overriding of log files correctly for all processes within the unified shell.

In drunc logging, there are options that allow the log files to append their timestamp in their filenames or not, effectively allowing them to be either overwritten or not.

Running

drunc-unified-shell (-no / -o)  ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config emir-test

will alter the behaviour of the SSH_SHELL_process_manager log file, and also save the override_log choice in UnifiedShellContext.

Inside the drunc-unified-shell, running

boot (--no-override-logs / --override-logs)

will now check for several things. If any of the flags is passed, it the boot command will parse that choice into the boot process correctly. If no flag is passed, boot will then obtain from the UnifiedShellContext the choice when initialising the unified shell and use that instead

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)
    • Only for the files in this PR, other files not related are changed, beyond scope of this PR so not added

Testing checklist

Check out latest nightly (tested on NFD_DEV_260109_A9) and this branch. Run various combinations of

drunc-unified-shell (-no / -o)  ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config emir-test
boot (--no-override-logs / --override-logs)

What you should see is:

  • If drunc unified shell has no options, it will pass the override by default (eg no timestamps)
  • Drunc unified shell should directly affect SSH_SHELL_process_manager, and boot affects everything else
  • If running boot with no flags passed, it will follow whatever was in drunc-unified-shell. Check for both cases
  • If running boot with a flag passed, will follow that flag for most of the other logs. Check for all cases.

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@emmuhamm emmuhamm self-assigned this Jan 15, 2026
@emmuhamm emmuhamm marked this pull request as draft January 15, 2026 13:59
@emmuhamm emmuhamm force-pushed the emmuhamm/propagate-override-logs branch from 7b3d223 to b65b961 Compare January 19, 2026 14:51
@emmuhamm emmuhamm force-pushed the emmuhamm/propagate-override-logs branch from 091a4ba to 27be248 Compare January 20, 2026 09:14
@emmuhamm emmuhamm marked this pull request as ready for review January 20, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: override-logs and no-override-logs do not propagate correctly.

2 participants