Skip to content

Conversation

@emmuhamm
Copy link
Contributor

@emmuhamm emmuhamm commented Jan 21, 2026

Description

Tackle #36 (not fully resolved)

Note during development of this there was a bug when using any kind of stream handler fisrt, and then using the ERS functionality. This is because streamhandler uses LoggingFormatter which alters the log record with padding. Obtaining the correct dunedaq ers gets bugged because when calling loglevel it gives 'CRITICAL ' due to padding, and that wont get it.

This is fixed here as well by using the ints instead
WIP

If full decription and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.

Addresses issue #

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@emmuhamm emmuhamm self-assigned this Jan 21, 2026
@emmuhamm emmuhamm force-pushed the emmuhamm/new-handlers branch from 5a05edb to 4a16756 Compare January 22, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants