Move jury submission source edit details to modal #3197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Kevinjil
force-pushed
the
source-edit-modal
branch
from
34d2c2f to
d849f22
Compare
vmcj
approved these changes
Nov 14, 2025
Member
vmcj
left a comment
vmcj
left a comment
There was a problem hiding this comment.
I assume you checked that everything is still prefilled such as the problem & language?
Previously, we always rendered the submission details (problem, language, entry point) form below the code editor. This prevents us from scaling the editor window to use all available height. We move this forum to a modal, triggered by a submit button on the top right of the IDE. This uses the same design as the proposed changes for the diff editor.
Kevinjil
force-pushed
the
source-edit-modal
branch
from
d849f22 to
5f93d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we always rendered the submission details (problem, language, entry point) form below the code editor. This prevents us from scaling the editor window to use all available height (towards #3058).
We move this form to a modal, triggered by a submit button on the top right of the IDE. This uses the same design as the proposed changes for the diff editor (#3132).
Screenshot:
